GTK: Add TRACE_EVENTs around gtk ui events.

GTK: Add TRACE_EVENTs around gtk ui events so select tasks related to the GTK user interface show up on the chrome://tracing hierarchical profiler.

These were useful for tracking down tab changing speed problems.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113939

[Elliot Glaysher, 2011-12-06 00:48:22]

jam: content/
estade: *_gtk.*
willchan: base/

[jam, 2011-12-06 01:43:51]

content lgtm

[willchan no longer on Chromium, 2011-12-06 02:59:46]

Is this on for Release mode too? Or just stripped out in official? It looks like
there's a central TraceLog with a mutex, so it's not inconceivable that this may
lead to contention.

LGTM, although if it runs on Release, then you should watch out for potential
page cycler regressions and what not.

http://codereview.chromium.org/8800029/diff/1/base/message_pump_gtk.cc
File base/message_pump_gtk.cc (right):

http://codereview.chromium.org/8800029/diff/1/base/message_pump_gtk.cc#newcode15
base/message_pump_gtk.cc:15: const char* EventToType(GdkEvent* event) {
Nit: const GdkEvent*?

[Elliot Glaysher, 2011-12-06 22:24:51]

ping estade for gtk review

On 2011/12/06 02:59:46, willchan wrote:
> Is this on for Release mode too?

The UNSHIPPED_ versions turn this off in OFFICIAL_BUILDs. I'm not worried about
the overhead since there's an UNSHIPPED_TRACE_EVENT2 in MessageLoop::RunTask().

[Evan Stade, 2011-12-07 00:48:50]

why is there no bug number and essentially no CL description, I have no context
what this change is about or for.

http://codereview.chromium.org/8800029/diff/6001/base/message_pump_gtk.cc
File base/message_pump_gtk.cc (right):

http://codereview.chromium.org/8800029/diff/6001/base/message_pump_gtk.cc#new...
base/message_pump_gtk.cc:15: const char* EventToType(const GdkEvent* event) {
Why EventToType? Why not EventTypeToString?

[Elliot Glaysher, 2011-12-07 01:19:59]

Updated change description to point out that this is for chrome://tracing.

http://codereview.chromium.org/8800029/diff/6001/base/message_pump_gtk.cc
File base/message_pump_gtk.cc (right):

http://codereview.chromium.org/8800029/diff/6001/base/message_pump_gtk.cc#new...
base/message_pump_gtk.cc:15: const char* EventToType(const GdkEvent* event) {
On 2011/12/07 00:48:50, Evan Stade wrote:
> Why EventToType? Why not EventTypeToString?

Change to EventToTypeString

[Elliot Glaysher, 2011-12-09 19:10:51]

ping estade

[Evan Stade, 2011-12-09 22:40:19]

thanks. lgtm

[commit-bot: I haz the power, 2011-12-09 22:45:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8800029/11001

[commit-bot: I haz the power, 2011-12-09 22:45:13]

Can't apply patch for file chrome/browser/ui/gtk/download/download_item_gtk.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/ui/gtk/download/download_item_gtk.cc
Hunk #2 succeeded at 700 with fuzz 2.
Hunk #3 succeeded at 767 (offset -3 lines).
Hunk #4 FAILED at 817.
1 out of 5 hunks FAILED -- saving rejects to file
chrome/browser/ui/gtk/download/download_item_gtk.cc.rej

[commit-bot: I haz the power, 2011-12-09 22:57:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8800029/17001

[commit-bot: I haz the power, 2011-12-10 00:29:04]

Can't apply patch for file chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc
Hunk #1 FAILED at 4.
Hunk #2 succeeded at 964 (offset 2 lines).
Hunk #3 succeeded at 1039 (offset 2 lines).
Hunk #4 succeeded at 1610 (offset 2 lines).
Hunk #5 succeeded at 1808 (offset 2 lines).
Hunk #6 succeeded at 1997 (offset 2 lines).
Hunk #7 succeeded at 2078 (offset 2 lines).
1 out of 7 hunks FAILED -- saving rejects to file
chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc.rej

[commit-bot: I haz the power, 2011-12-10 01:49:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8800029/19002

[commit-bot: I haz the power, 2011-12-10 04:01:54]

Change committed as 113939