Issue 8800017: Change SkFileDescriptorStream to handle failure to open the file descriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8800017: Change SkFileDescriptorStream to handle failure to open the file descriptor (Closed)

Created:
9 years ago by reed1

Modified:
9 years ago

Reviewers:
bungeman-skia, vandebo (ex-Chrome)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Change SkFileDescriptorStream to handle failure to open the file descriptor (by initializing its length_ to 0), and to return the number of bytes skipped if buffer==null, rather than returning the offset. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113197

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -11 lines)			Patch
	M	skia/ext/SkFontHost_fontconfig.cpp	View		2 chunks	+4 lines, -11 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

9 years ago (2011-12-05 21:02:44 UTC) #2

LGTM, with one questionable nit.

http://codereview.chromium.org/8800017/diff/1/skia/ext/SkFontHost_fontconfig.cpp
File skia/ext/SkFontHost_fontconfig.cpp (right):

http://codereview.chromium.org/8800017/diff/1/skia/ext/SkFontHost_fontconfig....
skia/ext/SkFontHost_fontconfig.cpp:246: length_ = 0;
This is following the existing convention, but should these not be set in the
initialization list?

Expand Messages | Collapse Messages