Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4874)

Unified Diff: chrome/browser/extensions/external_extension_provider_impl.cc

Issue 8800016: Exempt default apps from external-extension alerts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Suggestions from Roger. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_extension_provider_impl.cc
diff --git a/chrome/browser/extensions/external_extension_provider_impl.cc b/chrome/browser/extensions/external_extension_provider_impl.cc
index b8fbdb005fa31f1a7c077defd26bb6c6e8809103..cc1dd9b87b8fdc9e4669a43cee6dff04612a9442 100644
--- a/chrome/browser/extensions/external_extension_provider_impl.cc
+++ b/chrome/browser/extensions/external_extension_provider_impl.cc
@@ -56,7 +56,8 @@ ExternalExtensionProviderImpl::ExternalExtensionProviderImpl(
prefs_(NULL),
ready_(false),
loader_(loader),
- creation_flags_(creation_flags) {
+ creation_flags_(creation_flags),
+ auto_acknowledge_(false) {
loader_->Init(this);
}
@@ -73,7 +74,7 @@ void ExternalExtensionProviderImpl::VisitRegisteredExtension() {
void ExternalExtensionProviderImpl::SetPrefs(DictionaryValue* prefs) {
CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- // Check if the service is still alive. It is possible that it had went
+ // Check if the service is still alive. It is possible that it went
// away while |loader_| was working on the FILE thread.
if (!service_) return;
@@ -196,7 +197,8 @@ void ExternalExtensionProviderImpl::SetPrefs(DictionaryValue* prefs) {
continue;
}
service_->OnExternalExtensionFileFound(extension_id, version.get(), path,
- crx_location_, creation_flags_);
+ crx_location_, creation_flags_,
+ auto_acknowledge_);
} else { // if (has_external_update_url)
CHECK(has_external_update_url); // Checking of keys above ensures this.
if (download_location_ == Extension::INVALID) {

Powered by Google App Engine
This is Rietveld 408576698