Exempt default apps from external-extension alerts.

Exempt default apps from external-extension alerts.

BUG=106188
TEST=added


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113144

[Roger Tawa OOO till Jul 10th, 2011-12-05 19:42:37]

lgtm

A couple of nits to rename variables: while reading the code, it was not clear
to me if "acknowledge" meant "ask the user to acknowledge" or "has already been
acknowledged".  However, could be just me, so rename if you like.

http://codereview.chromium.org/8800016/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_service.h (right):

http://codereview.chromium.org/8800016/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_service.h:509: bool should_acknowledge)
rename to mark_as_acknowledged ?

http://codereview.chromium.org/8800016/diff/1/chrome/browser/extensions/exter...
File chrome/browser/extensions/external_extension_provider_impl.h (right):

http://codereview.chromium.org/8800016/diff/1/chrome/browser/extensions/exter...
chrome/browser/extensions/external_extension_provider_impl.h:108: bool
should_acknowledge_;
maybe rename this to auto_acknowledge_ ?

[asargent_no_longer_on_chrome, 2011-12-06 00:39:52]

lgtm

[miket_OOO, 2011-12-06 01:21:33]

Sending to the queue. Thanks!

http://codereview.chromium.org/8800016/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_service.h (right):

http://codereview.chromium.org/8800016/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_service.h:509: bool should_acknowledge)
On 2011/12/05 19:42:38, Roger Tawa wrote:
> rename to mark_as_acknowledged ?

Sure!

[commit-bot: I haz the power, 2011-12-06 01:21:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/8800016/4001

[commit-bot: I haz the power, 2011-12-06 07:29:53]

Change committed as 113144