Issue 8800012: Ignore the correct synchronization in __sfp on Mac that isn't handled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8800012: Ignore the correct synchronization in __sfp on Mac that isn't handled (Closed)

Created:
9 years ago by Alexander Potapenko

Modified:
9 years ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Ignore the correct synchronization in __sfp on Mac that isn't handled by ThreadSanitizer. We don't need the suppression anymore. BUG=106197 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113169

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -12 lines)			Patch
	M	tools/valgrind/tsan/ignores_mac.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tools/valgrind/tsan/suppressions_mac.txt	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

LGTM Please make sure this ignore is enough, as I often saw fun_r ignores not ...

9 years ago (2011-12-05 17:35:55 UTC) #2

Timur Iskhodzhanov

9 years ago (2011-12-06 12:28:52 UTC) #3

On 2011/12/05 17:35:55, Timur Iskhodzhanov wrote:
> LGTM
> 
> Please make sure this ignore is enough, as I often saw fun_r ignores not
working
> properly due to tail calls and similar optimizations
Ping!
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28...

Expand Messages | Collapse Messages