Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 8800010: Update CreateTabContents to use a content::Referrer instead of a plain URL (Closed)

Created:
9 years ago by jochen (gone - plz use gerrit)
Modified:
9 years ago
Reviewers:
battre
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Update CreateTabContents to use a content::Referrer instead of a plain URL BUG=105028 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113161

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M chrome/browser/tabs/default_tab_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tabs/default_tab_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model_delegate.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
plz review
9 years ago (2011-12-05 16:10:57 UTC) #1
battre
lgtm
9 years ago (2011-12-05 16:17:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8800010/3001
9 years ago (2011-12-05 21:14:09 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years ago (2011-12-05 23:52:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8800010/3001
9 years ago (2011-12-06 06:26:52 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-06 08:05:10 UTC) #6
Change committed as 113161

Powered by Google App Engine
This is Rietveld 408576698