Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6417)

Unified Diff: chrome/common/extensions/url_pattern.cc

Issue 8800006: Support chrome-extension:// scheme in URLPattern. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed jam's comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/url_pattern.cc
diff --git a/chrome/common/extensions/url_pattern.cc b/chrome/common/extensions/url_pattern.cc
index 91664f5dbebc8d52e5b614b76a1cbf7414048f22..f9ac0c96aaa26e499e09e06042eb009dc453abed 100644
--- a/chrome/common/extensions/url_pattern.cc
+++ b/chrome/common/extensions/url_pattern.cc
@@ -16,8 +16,7 @@ const char URLPattern::kAllUrlsPattern[] = "<all_urls>";
namespace {
-// TODO(aa): Consider adding chrome-extension? What about more obscure ones
-// like data: and javascript: ?
+// TODO(aa): What about more obscure schemas like data: and javascript: ?
Aaron Boodman 2011/12/06 06:40:31 Nit: s/schemas/schemes/
battre 2011/12/06 12:51:35 Done.
// Note: keep this array in sync with kValidSchemeMasks.
const char* kValidSchemes[] = {
chrome::kHttpScheme,
@@ -25,6 +24,7 @@ const char* kValidSchemes[] = {
chrome::kFileScheme,
chrome::kFtpScheme,
chrome::kChromeUIScheme,
+ chrome::kExtensionScheme,
chrome::kFileSystemScheme,
};
@@ -34,6 +34,7 @@ const int kValidSchemeMasks[] = {
URLPattern::SCHEME_FILE,
URLPattern::SCHEME_FTP,
URLPattern::SCHEME_CHROMEUI,
+ URLPattern::SCHEME_EXTENSION,
URLPattern::SCHEME_FILESYSTEM,
};

Powered by Google App Engine
This is Rietveld 408576698