chrome/browser/extensions/extension_tabs_module.cc - Issue 8800006: Support chrome-extension:// scheme in URLPattern.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 8800006: Support chrome-extension:// scheme in URLPattern. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Improved documentation Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/browser/extensions/extension_tabs_module.cc

diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc

index 71d3b83233ddd2b9e28e3c0de505a5170dbc1290..5f33e3a113317cc1bbe087266bcb6931ce54522a 100644

--- a/chrome/browser/extensions/extension_tabs_module.cc

+++ b/chrome/browser/extensions/extension_tabs_module.cc

@@ -727,6 +727,9 @@ bool QueryTabsFunction::RunImpl() {

loading = (status == keys::kStatusValueLoading) ? MATCH_TRUE : MATCH_FALSE;

}

+ // It is o.k. to use URLPattern::SCHEME_ALL here because this function does

+ // not grant access to the content of the tabs, only to seeing their URLs and

+ // meta data.

URLPattern url_pattern(URLPattern::SCHEME_ALL, "<all_urls>");

if (query->HasKey(keys::kUrlKey)) {

std::string value;