Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8800002: Remove views::InputMethodIBus. (Closed)

Created:
9 years ago by Yusuke Sato
Modified:
8 years, 12 months ago
Reviewers:
Peng, James Su, sky
CC:
chromium-reviews, tfarina, ben+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org, oshima
Visibility:
Public.

Description

Remove views::InputMethodIBus. We should instead use the new ui::InputMethodIBus implementation. BUG=None TEST=try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113574 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115870

Patch Set 1 #

Patch Set 2 : rebase, review #

Patch Set 3 : rebase #

Patch Set 4 : fix cros build (where HAVE_IBUS is #defined) #

Patch Set 5 : final rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1194 lines) Patch
D ui/views/ime/input_method_ibus.h View 1 chunk +0 lines, -201 lines 0 comments Download
D ui/views/ime/input_method_ibus.cc View 1 2 3 4 1 chunk +0 lines, -964 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 4 2 chunks +0 lines, -16 lines 0 comments Download
M ui/views/widget/native_widget_gtk.cc View 1 2 3 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Yusuke Sato
9 years ago (2011-12-06 07:02:16 UTC) #1
James Su
On 2011/12/06 07:02:16, Yusuke Sato wrote: LGTM.
9 years ago (2011-12-06 07:08:25 UTC) #2
sky
LGTM
9 years ago (2011-12-06 16:01:10 UTC) #3
Peng
On 2011/12/06 16:01:10, sky wrote: > LGTM lgtm
9 years ago (2011-12-06 18:49:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8800002/7001
9 years ago (2011-12-08 07:01:45 UTC) #5
commit-bot: I haz the power
Change committed as 113574
9 years ago (2011-12-08 08:20:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8800002/12001
8 years, 12 months ago (2011-12-27 04:28:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8800002/12001
8 years, 12 months ago (2011-12-28 02:43:03 UTC) #8
commit-bot: I haz the power
8 years, 12 months ago (2011-12-28 03:53:21 UTC) #9 
Change committed as 115870

Powered by Google App Engine
This is Rietveld 408576698