Issue 8799020: process all ui events before posting closure because menu depends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8799020: process all ui events before posting closure because menu depends (Closed)

Created:
9 years ago by oshima

Modified:
9 years ago

Reviewers:
sky

CC:
chromium-reviews, robertshield, kkania, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

process all ui events before posting closure because menu depends on ui events to quit. Add new RunClosureAfterAllPendingUIEvents for toolkit views. BUG=104359 TEST=BookmarkBarViewTest in interactive_ui_tests will pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113177

Patch Set 1 #

Patch Set 2 : win fix #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -25 lines)			Patch
M	chrome/browser/automation/ui_controls.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/ui_controls_aurawin.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/ui_controls_aurax11.cc	View	1	6 chunks	+20 lines, -22 lines	0 comments	Download
M	chrome/browser/automation/ui_controls_gtk.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/ui_controls_internal.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/automation/ui_controls_win.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/test/base/view_event_test_base.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8799020/1

9 years ago (2011-12-05 23:47:24 UTC) #3

commit-bot: I haz the power

Try job failure for 8799020-1 (retry) on win_rel for step "compile" (clobber build). It's a ...

9 years ago (2011-12-06 02:07:05 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8799020/8003

9 years ago (2011-12-06 09:02:58 UTC) #5

Change committed as 113177

Expand Messages | Collapse Messages