Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: tools/testing/dart/test_options.dart

Issue 8799009: Add support for client/dartc compilation only tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/test.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index 5b7acdf5e392a1887b7e3d7bcc97895b94756aa6..093e9aba0d130b7fa9f8fddabf67c45da52f74fd 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -5,7 +5,7 @@
#library("test_options_parser");
List<String> defaultTestSelectors =
- const ['samples', 'standalone', 'corelib', 'co19', 'language',
+ const ['dartc', 'samples', 'standalone', 'corelib', 'co19', 'language',
'isolate', 'stub-generator', 'vm'];
/**
@@ -248,9 +248,11 @@ class TestOptionsParser {
if (slashLocation != -1) {
suite = pattern.substring(0, slashLocation);
pattern = pattern.substring(slashLocation + 1);
+ pattern = pattern.replaceAll('*', '.*');
+ pattern = pattern.replaceAll('/', '.*');
+ } else {
+ pattern = ".*";
}
- pattern = pattern.replaceAll('*', '.*');
- pattern = pattern.replaceAll('/', '.*');
if (selectorMap.containsKey(suite)) {
print("Warning: selector '$suite/$pattern' overrides " +
"previous selector for suite '$suite'");
« no previous file with comments | « tools/test.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698