Replace the Slideshow with the Photo Editor

Replace the Slideshow with the Photo Editor


BUG=chromium-os:23750
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113236

[dgozman, 2011-12-05 11:47:33]

LGTM with comments addressed

What is that strange file resources/slideshow.html ?

http://codereview.chromium.org/8799006/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_file_browser_private_api.cc (right):

http://codereview.chromium.org/8799006/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_file_browser_private_api.cc:1682:
dict->SetString("PLAY_MEDIA",
Maybe, we do not use this too?

http://codereview.chromium.org/8799006/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/file_manager.js (left):

http://codereview.chromium.org/8799006/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:2086: // TODO(serya):
This hack needed until task.iconUrl get working
I think, you should keep this TODO (just move it below).

[Vladislav Kaznacheev, 2011-12-05 13:40:10]

http://codereview.chromium.org/8799006/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_file_browser_private_api.cc (right):

http://codereview.chromium.org/8799006/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_file_browser_private_api.cc:1682:
dict->SetString("PLAY_MEDIA",
We do use it.
On 2011/12/05 11:47:34, dgozman wrote:
> Maybe, we do not use this too?

http://codereview.chromium.org/8799006/diff/1/chrome/browser/resources/file_m...
File chrome/browser/resources/file_manager/js/file_manager.js (left):

http://codereview.chromium.org/8799006/diff/1/chrome/browser/resources/file_m...
chrome/browser/resources/file_manager/js/file_manager.js:2086: // TODO(serya):
This hack needed until task.iconUrl get working
On 2011/12/05 11:47:34, dgozman wrote:
> I think, you should keep this TODO (just move it below).

Done.

[commit-bot: I haz the power, 2011-12-05 13:40:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8799006/2002

[commit-bot: I haz the power, 2011-12-05 13:40:25]

Presubmit check for 8799006-2002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/resources/component_extension_resources.grd

Presubmit checks took 1.5s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Vladislav Kaznacheev, 2011-12-05 13:43:08]

Hi Erik,

Please review the change for
chrome/browser/resources/component_extension_resources.grd.

Thanks,

  Vlad

[commit-bot: I haz the power, 2011-12-06 14:08:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8799006/6001

[commit-bot: I haz the power, 2011-12-06 15:32:25]

Try job failure for 8799006-6001 (retry) on win_rel for step "unit_tests".
It's a second try, previously, step "unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-12-06 17:07:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/8799006/6001

[commit-bot: I haz the power, 2011-12-06 18:26:46]

Change committed as 113236

[arv (Not doing code reviews), 2011-12-06 21:39:26]

LGTM