Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 8796006: Add memcheck annotation and remove suppression. (Closed)

Created:
9 years ago by Reid Kleckner
Modified:
9 years ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add memcheck annotation and remove suppression. This is really re-landing 112937 and attempting to avoid a warning from the Linux builder. R=jar@chromium.org BUG=106326 TEST=needs to run on the CQ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112944

Patch Set 1 #

Patch Set 2 : Rebase onto trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M base/tracked_objects.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Reid Kleckner
9 years ago (2011-12-04 17:07:21 UTC) #1
jar (doing other things)
Clearly this change would be best landed *in* the macro definition. In the mean time, ...
9 years ago (2011-12-04 17:12:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/8796006/1
9 years ago (2011-12-04 17:13:29 UTC) #3
Reid Kleckner (google)
I brought it up with chrome-valgrind-team. If this actually works on the CQ (I can't ...
9 years ago (2011-12-04 17:14:46 UTC) #4
commit-bot: I haz the power
List of reviewers changed. rnk@google.com did a drive-by without LGTM'ing!
9 years ago (2011-12-04 18:28:40 UTC) #5
Reid Kleckner (google)
On 2011/12/04 18:28:40, I haz the power (commit-bot) wrote: > List of reviewers changed. mailto:rnk@google.com ...
9 years ago (2011-12-04 19:32:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/8796006/1
9 years ago (2011-12-04 19:32:23 UTC) #7
commit-bot: I haz the power
Can't apply patch for file tools/valgrind/memcheck/suppressions.txt. While running patch -p1 --forward --force; patching file tools/valgrind/memcheck/suppressions.txt ...
9 years ago (2011-12-04 19:32:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/8796006/5002
9 years ago (2011-12-04 19:38:53 UTC) #9
commit-bot: I haz the power
9 years ago (2011-12-04 21:14:06 UTC) #10
Change committed as 112944

Powered by Google App Engine
This is Rietveld 408576698