Issue 8796003: Repaint avatar button when setting icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8796003: Repaint avatar button when setting icon (Closed)

Created:
9 years ago by sail

Modified:
9 years ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Repaint avatar button when setting icon BUG=106229 TEST=Ran without my change and saw that the avatar icon would not change. Applied my fix and verified that the avatar icon changed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113087

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/ui/views/avatar_menu_button.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM http://codereview.chromium.org/8796003/diff/1/chrome/browser/ui/views/avatar_menu_button.cc File chrome/browser/ui/views/avatar_menu_button.cc (right): http://codereview.chromium.org/8796003/diff/1/chrome/browser/ui/views/avatar_menu_button.cc#newcode154 chrome/browser/ui/views/avatar_menu_button.cc:154: Nit: Extra newline?

9 years ago (2011-12-05 22:02:02 UTC) #2

sail

http://codereview.chromium.org/8796003/diff/1/chrome/browser/ui/views/avatar_menu_button.cc File chrome/browser/ui/views/avatar_menu_button.cc (right): http://codereview.chromium.org/8796003/diff/1/chrome/browser/ui/views/avatar_menu_button.cc#newcode154 chrome/browser/ui/views/avatar_menu_button.cc:154: On 2011/12/05 22:02:02, Peter Kasting wrote: > Nit: Extra ...

9 years ago (2011-12-05 22:04:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8796003/5001

9 years ago (2011-12-05 22:05:13 UTC) #4

Change committed as 113087

Expand Messages | Collapse Messages