base::Bind: Convert disk_cache_based_ssl_host_info.

net/base/test_completion_callback.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_TEST_COMPLETION_CALLBACK_H_
 #define NET_BASE_TEST_COMPLETION_CALLBACK_H_
 #pragma once
 
 #include "base/callback_old.h"
 #include "base/compiler_specific.h"
 #include "base/tuple.h"
 #include "net/base/completion_callback.h"
 
 //-----------------------------------------------------------------------------
 // completion callback helper
 
 // A helper class for completion callbacks, designed to make it easy to run
 // tests involving asynchronous operations.  Just call WaitForResult to wait
 // for the asynchronous operation to complete.
 //
 // NOTE: Since this runs a message loop to wait for the completion callback,
 // there could be other side-effects resulting from WaitForResult.  For this
 // reason, this class is probably not ideal for a general application.
 //
-class TestOldCompletionCallback : public CallbackRunner< Tuple1<int> > {
+
+// Base class overridden by custom implementations of TestCompletionCallback.
+class TestCompletionCallbackBase {
  public:
-  TestOldCompletionCallback();
-  virtual ~TestOldCompletionCallback();
+  void SetResult(int result);
+  int WaitForResult();
+  int GetResult(int result);
+  bool have_result() const { return have_result_; }
 
-  int WaitForResult();
+ protected:
+  TestCompletionCallbackBase();
 
-  int GetResult(int result);
+  int result_;
+  bool have_result_;
+  bool waiting_for_result_;
 
-  bool have_result() const { return have_result_; }
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TestCompletionCallbackBase);
+};

[csilv, 2011/12/06 00:56:08]

This is a pretty cool approach, although when we remove
TestOldCompletionCallback you'll probably get rid of the base-class, thus
removing the benefit of adding it.  No change required, just an observation.

[James Hawkins, 2011/12/06 17:25:12]

I don't think so; see the use of this base class to specialize a
CompletionCallback in this CL (http_cache_unittest.cc).

+
+class TestOldCompletionCallback : public TestCompletionCallbackBase,
+                                  public CallbackRunner< Tuple1<int> > {
+ public:
+  TestOldCompletionCallback() {};
+  virtual ~TestOldCompletionCallback() {}
 
   virtual void RunWithParams(const Tuple1<int>& params) OVERRIDE;
 
  private:
-  int result_;
-  bool have_result_;
-  bool waiting_for_result_;
+  DISALLOW_COPY_AND_ASSIGN(TestOldCompletionCallback);
 };
 
 namespace net {
 
-class TestCompletionCallback {
+class TestCompletionCallback : public TestCompletionCallbackBase {
  public:
   TestCompletionCallback();
   ~TestCompletionCallback();
 
-  int WaitForResult() { return old_callback_impl_.WaitForResult(); }
-
-  int GetResult(int result) { return old_callback_impl_.GetResult(result); }
-
-  bool have_result() const { return old_callback_impl_.have_result(); }
-
   const CompletionCallback& callback() const { return callback_; }
 
  private:
-  void OnComplete(int result);
+  const CompletionCallback callback_;
 
-  const CompletionCallback callback_;
-  TestOldCompletionCallback old_callback_impl_;
+  DISALLOW_COPY_AND_ASSIGN(TestCompletionCallback);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_TEST_COMPLETION_CALLBACK_H_