Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: ui/base/x/events_x.cc

Issue 8793002: aura-x11: Add support for xmodmap'ed pointer buttons. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/events.h ('k') | ui/base/x/x11_util.h » ('j') | ui/base/x/x11_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/x/events_x.cc
diff --git a/ui/base/x/events_x.cc b/ui/base/x/events_x.cc
index 3d3b7a65624efa1f29a59441e42b5192e4bd833d..59767293684217eb80346e35225ec65c75b3b887 100644
--- a/ui/base/x/events_x.cc
+++ b/ui/base/x/events_x.cc
@@ -11,6 +11,7 @@
#include "base/logging.h"
#include "ui/base/keycodes/keyboard_code_conversion_x.h"
#include "ui/base/touch/touch_factory.h"
+#include "ui/base/x/x11_util.h"
#include "ui/gfx/point.h"
#if !defined(TOOLKIT_USES_GTK)
@@ -78,7 +79,9 @@ int GetButtonMaskForX2Event(XIDeviceEvent* xievent) {
int buttonflags = 0;
for (int i = 0; i < 8 * xievent->buttons.mask_len; i++) {
if (XIMaskIsSet(xievent->buttons.mask, i)) {
- buttonflags |= GetEventFlagsForButton(i);
+ int button = (xievent->sourceid == xievent->deviceid) ?
+ ui::GetMappedButton(i) : i;
+ buttonflags |= GetEventFlagsForButton(button);
}
}
return buttonflags;
@@ -189,15 +192,16 @@ EventType EventTypeFromNative(const base::NativeEvent& native_event) {
static_cast<XIDeviceEvent*>(native_event->xcookie.data);
if (TouchFactory::GetInstance()->IsTouchDevice(xievent->sourceid))
return GetTouchEventType(native_event);
+ int button = EventButtonFromNative(native_event);
switch (xievent->evtype) {
case XI_ButtonPress:
- if (xievent->detail >= kMinWheelButton &&
- xievent->detail <= kMaxWheelButton)
+ if (button >= kMinWheelButton &&
+ button <= kMaxWheelButton)
return ET_MOUSEWHEEL;
return ET_MOUSE_PRESSED;
case XI_ButtonRelease:
- if (xievent->detail >= kMinWheelButton &&
- xievent->detail <= kMaxWheelButton)
+ if (button >= kMinWheelButton &&
+ button <= kMaxWheelButton)
return ET_MOUSEWHEEL;
return ET_MOUSE_RELEASED;
case XI_Motion:
@@ -237,8 +241,9 @@ int EventFlagsFromNative(const base::NativeEvent& native_event) {
int flags = GetButtonMaskForX2Event(xievent) |
GetEventFlagsFromXState(xievent->mods.effective);
const EventType type = EventTypeFromNative(native_event);
+ int button = EventButtonFromNative(native_event);
if ((type == ET_MOUSE_PRESSED || type == ET_MOUSE_RELEASED) && !touch)
- flags |= GetEventFlagsForButton(xievent->detail);
+ flags |= GetEventFlagsForButton(button);
return flags;
}
case XI_Motion:
@@ -285,6 +290,16 @@ gfx::Point EventLocationFromNative(const base::NativeEvent& native_event) {
return gfx::Point();
}
+int EventButtonFromNative(const base::NativeEvent& native_event) {
+ CHECK_EQ(GenericEvent, native_event->type);
+ XIDeviceEvent* xievent =
+ static_cast<XIDeviceEvent*>(native_event->xcookie.data);
+ int button = xievent->detail;
+
+ return (xievent->sourceid == xievent->deviceid) ?
+ ui::GetMappedButton(button) : button;
+}
+
KeyboardCode KeyboardCodeFromNative(const base::NativeEvent& native_event) {
return KeyboardCodeFromXKeyEvent(native_event);
}
@@ -306,13 +321,10 @@ bool IsMouseEvent(const base::NativeEvent& native_event) {
int GetMouseWheelOffset(const base::NativeEvent& native_event) {
int button;
- if (native_event->type == GenericEvent) {
- XIDeviceEvent* xiev =
- static_cast<XIDeviceEvent*>(native_event->xcookie.data);
- button = xiev->detail;
- } else {
+ if (native_event->type == GenericEvent)
+ button = EventButtonFromNative(native_event);
+ else
button = native_event->xbutton.button;
- }
switch (button) {
case 4:
#if defined(OS_CHROMEOS)
« no previous file with comments | « ui/base/events.h ('k') | ui/base/x/x11_util.h » ('j') | ui/base/x/x11_util.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698