Issue 8792006: base::Bind: Convert chrome_benchmarking_message_filter.cc.

Issue 8792006: base::Bind: Convert chrome_benchmarking_message_filter.cc. (Closed)

Created:
9 years ago by James Hawkins

Modified:
9 years ago

Reviewers:
csilv

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind: Convert chrome_benchmarking_message_filter.cc. BUG=none TEST=none R=csilv Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113263

Patch Set 2 : Review fix. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -21 lines)			Patch
M	chrome/browser/chrome_benchmarking_message_filter.cc	View	1	5 chunks	+27 lines, -21 lines	0 comments	Download
M	net/disk_cache/backend_impl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/disk_cache/backend_impl.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/disk_cache/disk_cache.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/disk_cache/in_flight_backend_io.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/disk_cache/in_flight_backend_io.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	net/disk_cache/mem_backend_impl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/disk_cache/mem_backend_impl.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	net/http/mock_http_cache.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/http/mock_http_cache.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

The x_sync bot redness is unrelated to this change (verified on the tryserver waterfall).

9 years ago (2011-12-05 04:23:24 UTC) #2

csilv

lgtm http://codereview.chromium.org/8792006/diff/1/chrome/browser/chrome_benchmarking_message_filter.cc File chrome/browser/chrome_benchmarking_message_filter.cc (right): http://codereview.chromium.org/8792006/diff/1/chrome/browser/chrome_benchmarking_message_filter.cc#newcode59 chrome/browser/chrome_benchmarking_message_filter.cc:59: clear_cache_helper_.reset(callback); rename the parameter 'helper'

9 years ago (2011-12-06 19:10:24 UTC) #3

James Hawkins

9 years ago (2011-12-06 21:56:48 UTC) #4

http://codereview.chromium.org/8792006/diff/1/chrome/browser/chrome_benchmark...
File chrome/browser/chrome_benchmarking_message_filter.cc (right):

http://codereview.chromium.org/8792006/diff/1/chrome/browser/chrome_benchmark...
chrome/browser/chrome_benchmarking_message_filter.cc:59:
clear_cache_helper_.reset(callback);
On 2011/12/06 19:10:24, csilv wrote:
> rename the parameter 'helper'

Done.

Expand Messages | Collapse Messages