Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 8790016: Add rough version pnacl shim commandlines to pnacl coordinator. (Closed)

Created:
9 years ago by jvoung - send to chromium...
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add rough version pnacl shim commandlines to pnacl coordinator. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2413 TEST= patch into nacl, manually build latest shim, run test. R=sehr@google.com,robertm@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvoung - send to chromium...
Forgot about this bit since the test was turned off (but turned back on friday). ...
9 years ago (2011-12-04 07:13:32 UTC) #1
sehr (please use chromium)
LGTM from me. But I'm going to replace it again soon :-)
9 years ago (2011-12-06 00:43:02 UTC) #2
jvoung - send to chromium...
On 2011/12/06 00:43:02, sehr wrote: > LGTM from me. But I'm going to replace it ...
9 years ago (2011-12-06 02:02:11 UTC) #3
jvoung - send to chromium...
9 years ago (2011-12-06 18:22:44 UTC) #4
On 2011/12/06 02:02:11, jvoung wrote:
> On 2011/12/06 00:43:02, sehr wrote:
> > LGTM from me.  But I'm going to replace it again soon :-)
> 
> I will refrain from wearing out the bits and leave this alone until you
replace
> it then =)

ok, n/m putting in for now then.

Powered by Google App Engine
This is Rietveld 408576698