Make SpdyFrame::size a constant instead of a static method so gcc can optimize the call away.

net/spdy/spdy_protocol_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_protocol.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "net/spdy/spdy_bitmasks.h"
 #include "net/spdy/spdy_framer.h"
 #include "testing/platform_test.h"
@@ skipping 30 matching lines @@
 using spdy::SpdyWindowUpdateControlFrame;
 using spdy::SettingsFlagsAndId;
 using spdy::kLengthMask;
 using spdy::kSpdyProtocolVersion;
 using spdy::kStreamIdMask;
 
 namespace {
 
 // Test our protocol constants
 TEST(SpdyProtocolTest, ProtocolConstants) {
-  EXPECT_EQ(8u, SpdyFrame::size());
+  EXPECT_EQ(8u, SpdyFrame::kHeaderSize);
   EXPECT_EQ(8u, SpdyDataFrame::size());
   EXPECT_EQ(8u, SpdyControlFrame::size());
   EXPECT_EQ(18u, SpdySynStreamControlFrame::size());
   EXPECT_EQ(14u, SpdySynReplyControlFrame::size());
   EXPECT_EQ(16u, SpdyRstStreamControlFrame::size());
   EXPECT_EQ(12u, SpdySettingsControlFrame::size());
   EXPECT_EQ(8u, SpdyNoOpControlFrame::size());
   EXPECT_EQ(12u, SpdyPingControlFrame::size());
   EXPECT_EQ(12u, SpdyGoAwayControlFrame::size());
   EXPECT_EQ(14u, SpdyHeadersControlFrame::size());
   EXPECT_EQ(16u, SpdyWindowUpdateControlFrame::size());
   EXPECT_EQ(4u, sizeof(FlagsAndLength));
   EXPECT_EQ(1, SYN_STREAM);
   EXPECT_EQ(2, SYN_REPLY);
   EXPECT_EQ(3, RST_STREAM);
   EXPECT_EQ(4, SETTINGS);
   EXPECT_EQ(5, NOOP);
   EXPECT_EQ(6, PING);
   EXPECT_EQ(7, GOAWAY);
   EXPECT_EQ(8, HEADERS);
   EXPECT_EQ(9, WINDOW_UPDATE);
 }
 
 // Test some of the protocol helper functions
 TEST(SpdyProtocolTest, FrameStructs) {
-  SpdyFrame frame(SpdyFrame::size());
+  SpdyFrame frame(SpdyFrame::kHeaderSize);
   frame.set_length(12345);
   frame.set_flags(10);
   EXPECT_EQ(12345u, frame.length());
   EXPECT_EQ(10u, frame.flags());
   EXPECT_FALSE(frame.is_control_frame());
 
   frame.set_length(0);
   frame.set_flags(10);
   EXPECT_EQ(0u, frame.length());
   EXPECT_EQ(10u, frame.flags());
@@ skipping 285 matching lines @@
 
   rst_frame->set_status(
       static_cast<spdy::SpdyStatusCodes>(spdy::INVALID - 1));
   EXPECT_EQ(spdy::INVALID, rst_frame->status());
 
   rst_frame->set_status(spdy::NUM_STATUS_CODES);
   EXPECT_EQ(spdy::INVALID, rst_frame->status());
 }
 
 }  // namespace