Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 8790012: Fix TabRestoreServiceTest and TranslateManagerTest when using use_webkit_compositor=1 (Closed)

Created:
9 years ago by piman
Modified:
9 years ago
Reviewers:
oshima
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke-watch+content_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix TabRestoreServiceTest and TranslateManagerTest when using use_webkit_compositor=1 BUG=106157 TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113288

Patch Set 1 #

Patch Set 2 : better fix #

Total comments: 2

Patch Set 3 : fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/sessions/tab_restore_service_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 2 4 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
piman
9 years ago (2011-12-06 00:49:27 UTC) #1
oshima
http://codereview.chromium.org/8790012/diff/2001/chrome/browser/translate/translate_manager_browsertest.cc File chrome/browser/translate/translate_manager_browsertest.cc (right): http://codereview.chromium.org/8790012/diff/2001/chrome/browser/translate/translate_manager_browsertest.cc#newcode41 chrome/browser/translate/translate_manager_browsertest.cc:41: #include "third_party/WebKit/Source/WebKit/chromium/public/WebKit.h" move new includes into "if defined(USE_WEBKIT_COMPOSITOR)
9 years ago (2011-12-06 18:40:51 UTC) #2
oshima
and can you check linux_aura bot failure? On 2011/12/06 18:40:51, oshima wrote: > http://codereview.chromium.org/8790012/diff/2001/chrome/browser/translate/translate_manager_browsertest.cc > ...
9 years ago (2011-12-06 18:41:19 UTC) #3
piman
On Tue, Dec 6, 2011 at 10:41 AM, <oshima@chromium.org> wrote: > and can you check ...
9 years ago (2011-12-06 18:44:33 UTC) #4
piman
http://codereview.chromium.org/8790012/diff/2001/chrome/browser/translate/translate_manager_browsertest.cc File chrome/browser/translate/translate_manager_browsertest.cc (right): http://codereview.chromium.org/8790012/diff/2001/chrome/browser/translate/translate_manager_browsertest.cc#newcode41 chrome/browser/translate/translate_manager_browsertest.cc:41: #include "third_party/WebKit/Source/WebKit/chromium/public/WebKit.h" On 2011/12/06 18:40:51, oshima wrote: > move ...
9 years ago (2011-12-06 19:30:49 UTC) #5
oshima
LGTM
9 years ago (2011-12-06 19:31:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8790012/8001
9 years ago (2011-12-06 21:08:04 UTC) #7
commit-bot: I haz the power
Try job failure for 8790012-8001 (retry) on linux_clang for step "compile" (clobber build). It's a ...
9 years ago (2011-12-06 21:52:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8790012/8001
9 years ago (2011-12-06 21:58:41 UTC) #9
commit-bot: I haz the power
9 years ago (2011-12-06 23:41:29 UTC) #10
Change committed as 113288

Powered by Google App Engine
This is Rietveld 408576698