Issue 8790011: Roll libjingle to 99.

Issue 8790011: Roll libjingle to 99. (Closed)

Created:
9 years ago by Ronghua Wu (Left Chromium)

Modified:
9 years ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, jam, dpranke-watch+content_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, joi+watch-content_chromium.org, sergeyu+watch_chromium.org, niklase, juberti, webrtc-chrome-integration_google.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Roll libjingle to 98:99. - Refactoring and bug fixes - Remove global variables of class type.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
M	DEPS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/p2p/ipc_network_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/glue/fake_network_manager.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/notifier/base/notifier_options_util.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	remoting/jingle_glue/xmpp_signal_strategy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libjingle/libjingle.gyp	View		3 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

Currently libjingle unittests are not built as part of chrome so the CL description is ...

9 years ago (2011-12-05 18:44:58 UTC) #2

tommi (sloooow) - chröme

On 2011/12/05 18:44:58, sergeyu wrote: > Currently libjingle unittests are not built as part of ...

9 years ago (2011-12-05 20:07:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/8790011/3002

9 years ago (2011-12-05 20:07:49 UTC) #4

commit-bot: I haz the power

Can't apply patch for file DEPS. While running patch -p0 --forward --force; patching file DEPS ...

9 years ago (2011-12-05 20:07:51 UTC) #5

tommi (sloooow) - chröme

9 years ago (2011-12-05 20:40:22 UTC) #6

fyi - now attempting to land in a new cl to fix the merge issues:
http://codereview.chromium.org/8802019/

Expand Messages | Collapse Messages