chrome/browser/profiles/profile_metrics.cc - Issue 8790010: Adding in metrics for GAIA photo info. Also, fixing avatar logging to only log when the user chan...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_metrics.cc

Issue 8790010: Adding in metrics for GAIA photo info. Also, fixing avatar logging to only log when the user chan... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_metrics.h ('K') | « chrome/browser/profiles/profile_metrics.h ('k') | chrome/browser/ui/webui/options/manage_profile_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_metrics.cc

===================================================================

--- chrome/browser/profiles/profile_metrics.cc (revision 112673)

+++ chrome/browser/profiles/profile_metrics.cc (working copy)

@@ -113,6 +113,9 @@

case 25:

icon_name = AVATAR_SUN_CLOUD;

break;

+ case 27:

+ icon_name = AVATAR_GAIA;

+ break;

default: // We should never actually get here, but just in case

Ilya Sherman 2011/12/03 02:31:13 nit: Perhaps add a NOTREACHED() stmt here?

rpetterson 2011/12/05 20:27:14 Done.

icon_name = AVATAR_UNKNOWN;

break;

@@ -164,3 +167,9 @@

GetProfileType(profile_path),

NUM_PROFILE_TYPE_METRICS);

}

+void ProfileMetrics::LogProfileSwitchGaia(ProfileGaia metric) {

+ UMA_HISTOGRAM_ENUMERATION("Profile.SwitchGaiaPhotoSettings",

+ metric,

+ NUM_PROFILE_GAIA_METRICS);