Adding in metrics for GAIA photo info. Also, fixing avatar logging to only log when the user chan...

chrome/browser/profiles/profile_metrics.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 
 #include "base/basictypes.h"
 
 class FilePath;
 
 class ProfileMetrics {
  public:
   enum ProfileAvatar {
     AVATAR_GENERIC = 0,       // The names for avatar icons
     AVATAR_GENERIC_AQUA,
     AVATAR_GENERIC_BLUE,
     AVATAR_GENERIC_GREEN,
     AVATAR_GENERIC_ORANGE,
     AVATAR_GENERIC_PURPLE,
     AVATAR_GENERIC_RED,
     AVATAR_GENERIC_YELLOW,
     AVATAR_SECRET_AGENT,
     AVATAR_SUPERHERO,
-    AVATAR_VOLLEYBALL,
+    AVATAR_VOLLEYBALL,        // 10
     AVATAR_BUSINESSMAN,
     AVATAR_NINJA,
     AVATAR_ALIEN,
     AVATAR_AWESOME,
     AVATAR_FLOWER,
     AVATAR_PIZZA,
     AVATAR_SOCCER,
     AVATAR_BURGER,
     AVATAR_CAT,
-    AVATAR_CUPCAKE,
+    AVATAR_CUPCAKE,           // 20
     AVATAR_DOG,
     AVATAR_HORSE,
     AVATAR_MARGARITA,
     AVATAR_NOTE,
     AVATAR_SUN_CLOUD,
-    AVATAR_UNKNOWN,
+    AVATAR_UNKNOWN,            // 26
+    AVATAR_GAIA,               // 27

[Ilya Sherman, 2011/12/03 02:31:13]

nit: I think the alignment is off-by-one for these comments relative to the
others above.

[rpetterson, 2011/12/05 20:27:14]

Done.

     NUM_PROFILE_AVATAR_METRICS
   };

[Ilya Sherman, 2011/12/03 02:31:13]

nit: Hmm, I thought this enum got moved to the .cc file.  Does it need to live
in the .h file?

[rpetterson, 2011/12/05 20:27:14]

It was always in the .h. But it now has a new home in the .cc file. I moved the
call to log the GAIA Avatar selection into the SwitchGaia function so that it
was no longer needed outside the class.

 
   // Enum for counting the ways users were added.
   enum ProfileAdd {
     ADD_NEW_USER_ICON = 0,    // User adds new user from icon menu
     ADD_NEW_USER_MENU,        // User adds new user from menu bar
     NUM_PROFILE_ADD_METRICS
   };
 
   // Enum for counting the ways user profiles and menus were opened.
   enum ProfileOpen {
@@ skipping 22 matching lines @@
     SYNC_PASSPHRASE,          // User is using a passphrase
     NUM_PROFILE_SYNC_METRICS
   };
 
   enum ProfileType {
     ORIGINAL = 0,         // Refers to the original/default profile
     SECONDARY,            // Refers to a user-created profile
     NUM_PROFILE_TYPE_METRICS
   };
 
+  enum ProfileGaia {
+    GAIA_OPT_IN = 0,           // User changed to GAIA photo as avatar
+    GAIA_OPT_OUT,              // User changed to not use GAIA photo as avatar

[Ilya Sherman, 2011/12/03 02:31:13]

Hmm, is one of these the default, or are users somehow randomly assigned into
one group or the other?  If one is the default, these metrics might be a little
hard to interpret.  For example, let's say that you have 100 users, all of whom
start out using their GAIA photo as the avatar.  Then, 50% switch to a different
avatar.  Then 10% of those who switched switch back.  The way I'm imagining this
metric works, you'll see that 50 users opted out, and 5 user opted back in. 
From these numbers alone, you can't really recover the fact that 50% of your
users opted out initially -- which seems to me like the most interesting number.

LGTM if you're comfortable with this or have a different way to derive this
percentage, but just wanted to make sure that you have indeed thought about this
problem.

[rpetterson, 2011/12/05 20:27:14]

I understand what you're asking as I had the same discussion with Sailesh about
this. We're primarily interested in the numbers (and not the percentages) for
switching to avatar from GAIA but the other one is in there for sanity check.
That is, if we start to see equal numbers we know people are flipping back and
forth regularly.

+    NUM_PROFILE_GAIA_METRICS
+  };
+
   static void LogProfileAvatarSelection(size_t icon_index);
   static void LogProfileOpenMethod(ProfileOpen metric);
   static void LogProfileAddNewUser(ProfileAdd metric);
   static void LogProfileSwitchUser(ProfileOpen metric);
   static void LogProfileDeleteUser(ProfileNetUserCounts metric);
   static void LogProfileSyncInfo(ProfileSync metric);
   static void LogProfileUpdate(FilePath& profile_path);
   static void LogProfileSyncSignIn(FilePath& profile_path);
+  static void LogProfileSwitchGaia(ProfileGaia metric);
 };
 
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_