Issue 8790009: Regularize how ImageData and Graphics2D are created.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8790009: Regularize how ImageData and Graphics2D are created. (Closed)

Created:
9 years ago by brettw

Modified:
9 years ago

Reviewers:
bbudge

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Regularize how ImageData and Graphics2D are created. These objects were created differently than any other resoures. This cleans them up to behave like the other resources. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112946

Patch Set 1 #

Patch Set 2 : Fix comment #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+197 lines, -176 lines)			Patch
M	ppapi/proxy/ppapi_messages.h	View		3 chunks	+15 lines, -22 lines	0 comments	Download
M	ppapi/proxy/ppb_graphics_2d_proxy.h	View	1	1 chunk	+21 lines, -17 lines	0 comments	Download
M	ppapi/proxy/ppb_graphics_2d_proxy.cc	View		11 chunks	+41 lines, -28 lines	0 comments	Download
M	ppapi/proxy/ppb_image_data_proxy.h	View		2 chunks	+30 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppb_image_data_proxy.cc	View		2 chunks	+84 lines, -0 lines	0 comments	Download
M	ppapi/proxy/resource_creation_proxy.h	View		1 chunk	+0 lines, -19 lines	1 comment	Download
M	ppapi/proxy/resource_creation_proxy.cc	View		2 chunks	+3 lines, -86 lines	0 comments	Download
M	ppapi/shared_impl/api_id.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/thunk/interfaces_ppb_public_stable.h	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/8790009/diff/2001/ppapi/proxy/resource_creation_proxy.h File ppapi/proxy/resource_creation_proxy.h (left): http://codereview.chromium.org/8790009/diff/2001/ppapi/proxy/resource_creation_proxy.h#oldcode135 ppapi/proxy/resource_creation_proxy.h:135: void OnMsgCreateAudio(PP_Instance instance, These audio functions were never implemented ...

9 years ago (2011-12-03 00:40:38 UTC) #1

LGTM

Expand Messages | Collapse Messages