Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 8790006: Add download server IP address to the SafeBrowsing download protection ping. (Closed)

Created:
9 years ago by noelutz
Modified:
9 years ago
CC:
chromium-reviews, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add download server IP address to the SafeBrowsing download protection ping. BUG= TEST=No visible change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113129

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M chrome/browser/safe_browsing/download_protection_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 3 chunks +18 lines, -1 line 0 comments Download
M content/browser/download/download_create_info.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/download/download_item.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/download_item_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/mock_download_item.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
noelutz
9 years ago (2011-12-02 22:47:59 UTC) #1
Brian Ryner
lgtm for safe_browsing/
9 years ago (2011-12-02 23:01:21 UTC) #2
Randy Smith (Not in Mondays)
LGTM for content/browser/download/*.
9 years ago (2011-12-05 19:56:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelutz@google.com/8790006/1
9 years ago (2011-12-05 20:22:46 UTC) #4
commit-bot: I haz the power
Try job failure for 8790006-1 (retry) (previous was lost) on win_rel for step "unit_tests". It's ...
9 years ago (2011-12-06 00:16:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noelutz@google.com/8790006/1
9 years ago (2011-12-06 00:22:02 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-06 06:27:40 UTC) #7
Change committed as 113129

Powered by Google App Engine
This is Rietveld 408576698