Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1555)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 8789018: Revert 113047 - Make ExtensionService use ExtensionSet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.h
===================================================================
--- chrome/browser/extensions/extension_service.h (revision 113069)
+++ chrome/browser/extensions/extension_service.h (working copy)
@@ -41,7 +41,6 @@
#include "chrome/browser/sync/api/syncable_service.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_constants.h"
-#include "chrome/common/extensions/extension_set.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -87,7 +86,7 @@
typedef bool (*ExtensionFilter)(const Extension&);
virtual ~ExtensionServiceInterface() {}
- virtual const ExtensionSet* extensions() const = 0;
+ virtual const ExtensionList* extensions() const = 0;
virtual PendingExtensionManager* pending_extension_manager() = 0;
// Install an update. Return true if the install can be started.
@@ -193,9 +192,9 @@
virtual ~ExtensionService();
// Gets the list of currently installed extensions.
- virtual const ExtensionSet* extensions() const OVERRIDE;
- const ExtensionSet* disabled_extensions() const;
- const ExtensionSet* terminated_extensions() const;
+ virtual const ExtensionList* extensions() const OVERRIDE;
+ const ExtensionList* disabled_extensions() const;
+ const ExtensionList* terminated_extensions() const;
// Gets the object managing the set of pending extensions.
virtual PendingExtensionManager* pending_extension_manager() OVERRIDE;
@@ -631,7 +630,7 @@
// Appends sync data objects for every extension in |extensions|
// that passes |filter|.
void GetSyncDataListHelper(
- const ExtensionSet& extensions,
+ const ExtensionList& extensions,
const SyncBundle& bundle,
std::vector<ExtensionSyncData>* sync_data_list) const;
@@ -691,14 +690,17 @@
// The current list of installed extensions.
// TODO(aa): This should use chrome/common/extensions/extension_set.h.
- ExtensionSet extensions_;
+ ExtensionList extensions_;
// The list of installed extensions that have been disabled.
- ExtensionSet disabled_extensions_;
+ ExtensionList disabled_extensions_;
// The list of installed extensions that have been terminated.
- ExtensionSet terminated_extensions_;
+ ExtensionList terminated_extensions_;
+ // Used to quickly check if an extension was terminated.
+ std::set<std::string> terminated_extension_ids_;
+
// Hold the set of pending extensions.
PendingExtensionManager pending_extension_manager_;
Property changes on: chrome/browser/extensions/extension_service.h
___________________________________________________________________
Added: svn:mergeinfo
« no previous file with comments | « chrome/browser/extensions/extension_process_manager.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698