Issue 8789017: Add icons for Protector.

Issue 8789017: Add icons for Protector. (Closed)

Created:
9 years ago by Ivan Korotkov

Modified:
9 years ago

Reviewers:
whywhat

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add icons for Protector. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113168

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, --6 lines)			Patch
A	chrome/app/theme/protector_home_alert.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/protector_home_badge.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/protector_home_menu.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/protector_search_alert.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/protector_search_badge.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/protector_search_menu.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	2 chunks	+6 lines, -0 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/8789017/1

9 years ago (2011-12-05 17:12:55 UTC) #3

commit-bot: I haz the power

Try job failure for 8789017-1 (retry) on win_rel for step "compile" (clobber build). It's a ...

9 years ago (2011-12-05 17:35:18 UTC) #4

whywhat

http://codereview.chromium.org/8789017/diff/1/chrome/app/theme/theme_resources.grd File chrome/app/theme/theme_resources.grd (right): http://codereview.chromium.org/8789017/diff/1/chrome/app/theme/theme_resources.grd#newcode269 chrome/app/theme/theme_resources.grd:269: <include name="IDR_SEARCH_ENGINE_CHANGE_ALERT" file="protector_search_alert.png" type="BINDATA" /> nit: I'd prefix all ...

9 years ago (2011-12-05 20:15:49 UTC) #5

Ivan Korotkov

9 years ago (2011-12-06 09:27:18 UTC) #6

http://codereview.chromium.org/8789017/diff/1/chrome/app/theme/theme_resource...
File chrome/app/theme/theme_resources.grd (right):

http://codereview.chromium.org/8789017/diff/1/chrome/app/theme/theme_resource...
chrome/app/theme/theme_resources.grd:269: <include
name="IDR_SEARCH_ENGINE_CHANGE_ALERT" file="protector_search_alert.png"
type="BINDATA" />
On 2011/12/05 20:15:49, whywhat wrote:
> nit: I'd prefix all resource names with IDR_PROTECTOR actually

They are not prefixed in strings, so I'd like to keep them in the same style.

Expand Messages | Collapse Messages