Fix up bookmarks bar folders to always be scrolled to the top when they are opened.

Fix up bookmarks bar folders to always be scrolled to the top when they are opened.

BUG=101099
TEST=
  1. Enable Full Keyboard Access in System Preferences
  2. Create a folder on the bookmarks bar containing many (20+) bookmarks.
  3. Press the Tab key until this folder is selected in the bookmarks bar.
  4. Press the Space key to open the folder.

  After these steps, the folder should look identical to how it looks when you click on it directly.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114104

[Ilya Sherman, 2011-12-03 07:56:25]

So, this CL seems to fix the bug, but it worries me that I don't understand
*why* this is necessary *only for keyboard access*.  Scott, Mike, does this ring
any bells for you?  Do you perchance know of another, less arbitrary-seeming way
to achieve this same effect?

[mrossetti, 2011-12-04 00:31:01]

I don't see any difference in behavior — with or without the patch, tabbing into
a bookmark bar folder that's large enough to scroll exhibits the rapid scrolling
of its contents. I've not seen the scrambling though, with or without the patch.

[Ilya Sherman, 2011-12-05 23:25:22]

On 2011/12/04 00:31:01, mrossetti wrote:
> I don't see any difference in behavior — with or without the patch, tabbing
into
> a bookmark bar folder that's large enough to scroll exhibits the rapid
scrolling
> of its contents. I've not seen the scrambling though, with or without the
patch.

The bug occurs for me with bookmark folders that are *not* large enough to
scroll, but still have a bunch (20+) bookmarks in them.  I realized when trying
to repro the bug that the contents aren't being scrambled, but rather that the
view is being sized in some odd way, pushing some of the contents outside of the
view (but again, not in a scrollable way).  See my and Scott's comments on the
bug for a screenshot and a video capture of what this looks like.  (It's really
weird to me that it works differently across our computers :/)

[mrossetti, 2011-12-06 00:47:35]

Ah! Thanks for clearing up the mystery! LGTM

[Ilya Sherman, 2011-12-06 23:04:17]

Scott, how do you feel about this CL?  Does this look ok, or do you think there
might be something moar bettar to do here?

[Ilya Sherman, 2011-12-12 21:30:48]

Ok, I'm going to take Scott's silence for implicit assent.  Commit queue,
engage!

[commit-bot: I haz the power, 2011-12-12 21:31:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/8789010/7001

[Scott Hess - ex-Googler, 2011-12-12 21:32:59]

On 2011/12/12 21:30:48, Ilya Sherman wrote:
> Ok, I'm going to take Scott's silence for implicit assent.  Commit queue,
> engage!

LGTM, in the sense of I suspect there's something screwy going on here, but I
just don't want to look at it anymore.  Sorry to let my foibles slow things
down.

[commit-bot: I haz the power, 2011-12-12 22:40:33]

Change committed as 114104