Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: frog/element.dart

Issue 8789008: Fix "extends" checks. Move them out of resolve phase and do them on demand. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/minfrog » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/element.dart
diff --git a/frog/element.dart b/frog/element.dart
index 8efe2207d861bc0f4d98c26ab6a74f666d73bf78..7cd199af5dbc1d4222976294dd0a9ecf8ce77cbf 100644
--- a/frog/element.dart
+++ b/frog/element.dart
@@ -103,14 +103,7 @@ class Element implements Hashable {
}
var typeArgs = [];
for (int i=0; i < typeRef.typeArguments.length; i++) {
- var extendsType = baseType.typeParameters[i].extendsType;
- var typeArg = resolveType(typeRef.typeArguments[i], typeErrors);
- typeArgs.add(typeArg);
-
- if (extendsType != null && typeArg is! ParameterType) {
- typeArg.ensureSubtypeOf(extendsType,
- typeRef.typeArguments[i].span, typeErrors);
- }
+ typeArgs.add(resolveType(typeRef.typeArguments[i], typeErrors));
}
typeRef.type = baseType.getOrMakeConcreteType(typeArgs);
} else if (node is FunctionTypeReference) {
« no previous file with comments | « no previous file | frog/minfrog » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698