Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 8788011: Disabling "Select all" chechbox when the dir is empty. (Closed)

Created:
9 years ago by SeRya
Modified:
9 years ago
Reviewers:
dgozman
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

Disabling "Select all" chechbox when the dir is empty. BUG=chromium-os:20156 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112980

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -11 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 5 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
SeRya
9 years ago (2011-12-03 17:26:37 UTC) #1
dgozman
LGTM
9 years ago (2011-12-05 09:31:39 UTC) #2
SeRya
"checked" state must be updated on the "splice" event as well. Please, review again.
9 years ago (2011-12-05 11:19:01 UTC) #3
dgozman
LGTM
9 years ago (2011-12-05 11:21:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/8788011/3002
9 years ago (2011-12-05 11:26:13 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-05 15:25:03 UTC) #6
Change committed as 112980

Powered by Google App Engine
This is Rietveld 408576698