Issue 8788007: Update these tests to use manifest_version 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8788007: Update these tests to use manifest_version 2. (Closed)

Created:
9 years ago by abarth-chromium

Modified:
9 years ago

Reviewers:
aa

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Update these tests to use manifest_version 2. TBR=aa Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112866

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/extensions/app_background_page_apitest.cc	View		5 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

LGTM On Fri, Dec 2, 2011 at 5:12 PM, <abarth@chromium.org> wrote: > Reviewers: aa, > ...

9 years ago (2011-12-03 02:03:46 UTC) #2

LGTM

On Fri, Dec 2, 2011 at 5:12 PM,  <abarth@chromium.org> wrote:
> Reviewers: aa,
>
> Description:
> Update these tests to use manifest_version 2.
>
> TBR=aa
>
> Please review this at http://codereview.chromium.org/8788007/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/extensions/app_background_page_apitest.cc
>
>
> Index: chrome/browser/extensions/app_background_page_apitest.cc
> ===================================================================
> --- chrome/browser/extensions/app_background_page_apitest.cc    (revision
> 112827)
> +++ chrome/browser/extensions/app_background_page_apitest.cc    (working
> copy)
> @@ -61,6 +61,7 @@
>       "{"
>       "  \"name\": \"App\","
>       "  \"version\": \"0.1\","
> +      "  \"manifest_version\": 2,"
>       "  \"app\": {"
>       "    \"urls\": ["
>       "      \"http://a.com/\""
> @@ -88,6 +89,7 @@
>       "{"
>       "  \"name\": \"App\","
>       "  \"version\": \"0.1\","
> +      "  \"manifest_version\": 2,"
>       "  \"app\": {"
>       "    \"urls\": ["
>       "      \"http://a.com/\""
> @@ -114,6 +116,7 @@
>       "{"
>       "  \"name\": \"App\","
>       "  \"version\": \"0.1\","
> +      "  \"manifest_version\": 2,"
>       "  \"app\": {"
>       "    \"urls\": ["
>       "      \"http://a.com/\""
> @@ -146,6 +149,7 @@
>       "{"
>       "  \"name\": \"App\","
>       "  \"version\": \"0.1\","
> +      "  \"manifest_version\": 2,"
>       "  \"app\": {"
>       "    \"urls\": ["
>       "      \"http://a.com/\""
> @@ -172,6 +176,7 @@
>       "{"
>       "  \"name\": \"App\","
>       "  \"version\": \"0.1\","
> +      "  \"manifest_version\": 2,"
>       "  \"app\": {"
>       "    \"urls\": ["
>       "      \"http://a.com/\""
>
>

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/8788007/1

9 years ago (2011-12-03 02:29:13 UTC) #3

Change committed as 112866

Expand Messages | Collapse Messages