Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: chrome/browser/extensions/app_notify_channel_ui.h

Issue 8787013: Fix the following issue in app notify login flow: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/app_notify_channel_ui.h
===================================================================
--- chrome/browser/extensions/app_notify_channel_ui.h (revision 112743)
+++ chrome/browser/extensions/app_notify_channel_ui.h (working copy)
@@ -68,10 +68,13 @@
// Have we registered ourself as a ProfileSyncServiceObserver?
bool observing_sync_;
- // This is for working around a bug where the first ProfileSyncServiceObserver
- // callback after starting the sync login process erroneously reports
- // SetupInProgress as false. See crbug.com/101842.
- bool got_first_sync_callback_;
+ // This is for working around a bug that ProfileSyncService calls
+ // ProfileSyncServiceObserver::OnStateChanged callback many times
+ // after ShowLoginDialog is called and before the wizard is
+ // actually visible to the user. So we record if the wizard was
+ // shown to user and then wait for wizard to get dismissed.
+ // See crbug.com/101842.
+ bool wizard_shown_to_user_;
DISALLOW_COPY_AND_ASSIGN(AppNotifyChannelUIImpl);
};
« no previous file with comments | « no previous file | chrome/browser/extensions/app_notify_channel_ui.cc » ('j') | chrome/browser/extensions/app_notify_channel_ui.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698