Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: chrome/browser/extensions/app_notify_channel_ui.h

Issue 8787013: Fix the following issue in app notify login flow: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/app_notify_channel_ui.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_APP_NOTIFY_CHANNEL_UI_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_APP_NOTIFY_CHANNEL_UI_H_
6 #define CHROME_BROWSER_EXTENSIONS_APP_NOTIFY_CHANNEL_UI_H_ 6 #define CHROME_BROWSER_EXTENSIONS_APP_NOTIFY_CHANNEL_UI_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 void StopObservingSync(); 61 void StopObservingSync();
62 62
63 Browser* browser_; 63 Browser* browser_;
64 TabContentsWrapper* wrapper_; 64 TabContentsWrapper* wrapper_;
65 std::string app_name_; 65 std::string app_name_;
66 AppNotifyChannelUI::Delegate* delegate_; 66 AppNotifyChannelUI::Delegate* delegate_;
67 67
68 // Have we registered ourself as a ProfileSyncServiceObserver? 68 // Have we registered ourself as a ProfileSyncServiceObserver?
69 bool observing_sync_; 69 bool observing_sync_;
70 70
71 // This is for working around a bug where the first ProfileSyncServiceObserver 71 // This is for working around a bug that ProfileSyncService calls
72 // callback after starting the sync login process erroneously reports 72 // ProfileSyncServiceObserver::OnStateChanged callback many times
73 // SetupInProgress as false. See crbug.com/101842. 73 // after ShowLoginDialog is called and before the wizard is
74 bool got_first_sync_callback_; 74 // actually visible to the user. So we record if the wizard was
75 // shown to user and then wait for wizard to get dismissed.
76 // See crbug.com/101842.
77 bool wizard_shown_to_user_;
75 78
76 DISALLOW_COPY_AND_ASSIGN(AppNotifyChannelUIImpl); 79 DISALLOW_COPY_AND_ASSIGN(AppNotifyChannelUIImpl);
77 }; 80 };
78 81
79 #endif // CHROME_BROWSER_EXTENSIONS_APP_NOTIFY_CHANNEL_UI_H_ 82 #endif // CHROME_BROWSER_EXTENSIONS_APP_NOTIFY_CHANNEL_UI_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/app_notify_channel_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698