Log server advertised protos and the selected

net/socket/ssl_client_socket.h

Index: net/socket/ssl_client_socket.h
===================================================================
--- net/socket/ssl_client_socket.h	(revision 112817)
+++ net/socket/ssl_client_socket.h	(working copy)
@@ -121,10 +121,16 @@
   //   kNextProtoNegotiated:  *proto is set to the negotiated protocol.
   //   kNextProtoNoOverlap:   *proto is set to the first protocol in the
   //                          supported list.

[agl, 2011/12/05 20:00:54]

I think it's worth extending this comment to mention the second argument.

[ramant (doing other things), 2011/12/05 22:08:24]

Done.

-  virtual NextProtoStatus GetNextProto(std::string* proto) = 0;
+  virtual NextProtoStatus GetNextProto(std::string* proto,
+                                       std::string* server_protos) = 0;
 
   static NextProto NextProtoFromString(const std::string& proto_string);
 
+  static const char* NextProtoStatusToString(
+      const SSLClientSocket::NextProtoStatus status);
+
+  static std::string ServerProtosToString(const std::string& server_protos);

[agl, 2011/12/05 20:00:54]

I would mention that this can be used with the second argument of |GetNextProto|
to construct a comma separated string.

[ramant (doing other things), 2011/12/05 22:08:24]

Done.

+
   static bool IgnoreCertError(int error, int load_flags);
 
   virtual bool was_npn_negotiated() const;