Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: net/socket/ssl_client_socket_pool_unittest.cc

Issue 8787011: Log server advertised protos and the selected (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/socket/ssl_client_socket_pool.cc ('k') | net/socket/ssl_client_socket_win.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_proxy_client_socket_pool.h" 5 #include "net/http/http_proxy_client_socket_pool.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "base/time.h" 10 #include "base/time.h"
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 EXPECT_FALSE(handle.is_initialized()); 375 EXPECT_FALSE(handle.is_initialized());
376 EXPECT_FALSE(handle.socket()); 376 EXPECT_FALSE(handle.socket());
377 377
378 EXPECT_EQ(OK, callback.WaitForResult()); 378 EXPECT_EQ(OK, callback.WaitForResult());
379 EXPECT_TRUE(handle.is_initialized()); 379 EXPECT_TRUE(handle.is_initialized());
380 EXPECT_TRUE(handle.socket()); 380 EXPECT_TRUE(handle.socket());
381 381
382 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle.socket()); 382 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle.socket());
383 EXPECT_TRUE(ssl_socket->was_npn_negotiated()); 383 EXPECT_TRUE(ssl_socket->was_npn_negotiated());
384 std::string proto; 384 std::string proto;
385 ssl_socket->GetNextProto(&proto); 385 std::string server_protos;
386 ssl_socket->GetNextProto(&proto, &server_protos);
386 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto), 387 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto),
387 SSLClientSocket::kProtoSPDY2); 388 SSLClientSocket::kProtoSPDY2);
388 } 389 }
389 390
390 TEST_F(SSLClientSocketPoolTest, DirectGotBonusSPDY) { 391 TEST_F(SSLClientSocketPoolTest, DirectGotBonusSPDY) {
391 StaticSocketDataProvider data; 392 StaticSocketDataProvider data;
392 socket_factory_.AddSocketDataProvider(&data); 393 socket_factory_.AddSocketDataProvider(&data);
393 SSLSocketDataProvider ssl(true, OK); 394 SSLSocketDataProvider ssl(true, OK);
394 ssl.next_proto_status = SSLClientSocket::kNextProtoNegotiated; 395 ssl.next_proto_status = SSLClientSocket::kNextProtoNegotiated;
395 ssl.next_proto = "spdy/2"; 396 ssl.next_proto = "spdy/2";
(...skipping 11 matching lines...) Expand all
407 EXPECT_FALSE(handle.is_initialized()); 408 EXPECT_FALSE(handle.is_initialized());
408 EXPECT_FALSE(handle.socket()); 409 EXPECT_FALSE(handle.socket());
409 410
410 EXPECT_EQ(OK, callback.WaitForResult()); 411 EXPECT_EQ(OK, callback.WaitForResult());
411 EXPECT_TRUE(handle.is_initialized()); 412 EXPECT_TRUE(handle.is_initialized());
412 EXPECT_TRUE(handle.socket()); 413 EXPECT_TRUE(handle.socket());
413 414
414 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle.socket()); 415 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle.socket());
415 EXPECT_TRUE(ssl_socket->was_npn_negotiated()); 416 EXPECT_TRUE(ssl_socket->was_npn_negotiated());
416 std::string proto; 417 std::string proto;
417 ssl_socket->GetNextProto(&proto); 418 std::string server_protos;
419 ssl_socket->GetNextProto(&proto, &server_protos);
418 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto), 420 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto),
419 SSLClientSocket::kProtoSPDY2); 421 SSLClientSocket::kProtoSPDY2);
420 } 422 }
421 423
422 TEST_F(SSLClientSocketPoolTest, SOCKSFail) { 424 TEST_F(SSLClientSocketPoolTest, SOCKSFail) {
423 StaticSocketDataProvider data; 425 StaticSocketDataProvider data;
424 data.set_connect_data(MockConnect(false, ERR_CONNECTION_FAILED)); 426 data.set_connect_data(MockConnect(false, ERR_CONNECTION_FAILED));
425 socket_factory_.AddSocketDataProvider(&data); 427 socket_factory_.AddSocketDataProvider(&data);
426 428
427 CreatePool(false, true /* http proxy pool */, true /* socks pool */); 429 CreatePool(false, true /* http proxy pool */, true /* socks pool */);
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
707 EXPECT_FALSE(handle->is_initialized()); 709 EXPECT_FALSE(handle->is_initialized());
708 EXPECT_FALSE(handle->socket()); 710 EXPECT_FALSE(handle->socket());
709 711
710 EXPECT_EQ(OK, callback.WaitForResult()); 712 EXPECT_EQ(OK, callback.WaitForResult());
711 EXPECT_TRUE(handle->is_initialized()); 713 EXPECT_TRUE(handle->is_initialized());
712 EXPECT_TRUE(handle->socket()); 714 EXPECT_TRUE(handle->socket());
713 715
714 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle->socket()); 716 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle->socket());
715 EXPECT_TRUE(ssl_socket->was_npn_negotiated()); 717 EXPECT_TRUE(ssl_socket->was_npn_negotiated());
716 std::string proto; 718 std::string proto;
717 ssl_socket->GetNextProto(&proto); 719 std::string server_protos;
720 ssl_socket->GetNextProto(&proto, &server_protos);
718 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto), 721 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto),
719 SSLClientSocket::kProtoSPDY2); 722 SSLClientSocket::kProtoSPDY2);
720 723
721 // TODO(rtenneti): MockClientSocket::GetPeerAddress returns 0 as the port 724 // TODO(rtenneti): MockClientSocket::GetPeerAddress returns 0 as the port
722 // number. Fix it to return port 80 and then use GetPeerAddress to AddAlias. 725 // number. Fix it to return port 80 and then use GetPeerAddress to AddAlias.
723 const addrinfo* address = test_hosts[0].addresses.head(); 726 const addrinfo* address = test_hosts[0].addresses.head();
724 SpdySessionPoolPeer pool_peer(session_->spdy_session_pool()); 727 SpdySessionPoolPeer pool_peer(session_->spdy_session_pool());
725 pool_peer.AddAlias(address, test_hosts[0].pair); 728 pool_peer.AddAlias(address, test_hosts[0].pair);
726 729
727 scoped_refptr<SpdySession> spdy_session; 730 scoped_refptr<SpdySession> spdy_session;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
794 EXPECT_FALSE(handle->is_initialized()); 797 EXPECT_FALSE(handle->is_initialized());
795 EXPECT_FALSE(handle->socket()); 798 EXPECT_FALSE(handle->socket());
796 799
797 EXPECT_EQ(OK, old_callback.WaitForResult()); 800 EXPECT_EQ(OK, old_callback.WaitForResult());
798 EXPECT_TRUE(handle->is_initialized()); 801 EXPECT_TRUE(handle->is_initialized());
799 EXPECT_TRUE(handle->socket()); 802 EXPECT_TRUE(handle->socket());
800 803
801 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle->socket()); 804 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle->socket());
802 EXPECT_TRUE(ssl_socket->was_npn_negotiated()); 805 EXPECT_TRUE(ssl_socket->was_npn_negotiated());
803 std::string proto; 806 std::string proto;
804 ssl_socket->GetNextProto(&proto); 807 std::string server_protos;
808 ssl_socket->GetNextProto(&proto, &server_protos);
805 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto), 809 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto),
806 SSLClientSocket::kProtoSPDY2); 810 SSLClientSocket::kProtoSPDY2);
807 811
808 // TODO(rtenneti): MockClientSocket::GetPeerAddress returns 0 as the port 812 // TODO(rtenneti): MockClientSocket::GetPeerAddress returns 0 as the port
809 // number. Fix it to return port 80 and then use GetPeerAddress to AddAlias. 813 // number. Fix it to return port 80 and then use GetPeerAddress to AddAlias.
810 const addrinfo* address = test_hosts[0].addresses.head(); 814 const addrinfo* address = test_hosts[0].addresses.head();
811 SpdySessionPoolPeer pool_peer(session_->spdy_session_pool()); 815 SpdySessionPoolPeer pool_peer(session_->spdy_session_pool());
812 pool_peer.AddAlias(address, test_hosts[0].pair); 816 pool_peer.AddAlias(address, test_hosts[0].pair);
813 817
814 scoped_refptr<SpdySession> spdy_session; 818 scoped_refptr<SpdySession> spdy_session;
815 rv = session_->spdy_session_pool()->GetSpdySessionFromSocket( 819 rv = session_->spdy_session_pool()->GetSpdySessionFromSocket(
816 test_hosts[0].pair, handle.release(), BoundNetLog(), 0, 820 test_hosts[0].pair, handle.release(), BoundNetLog(), 0,
817 &spdy_session, true); 821 &spdy_session, true);
818 EXPECT_EQ(0, rv); 822 EXPECT_EQ(0, rv);
819 823
820 EXPECT_TRUE(session_->spdy_session_pool()->HasSession(test_hosts[0].pair)); 824 EXPECT_TRUE(session_->spdy_session_pool()->HasSession(test_hosts[0].pair));
821 EXPECT_FALSE(session_->spdy_session_pool()->HasSession(test_hosts[1].pair)); 825 EXPECT_FALSE(session_->spdy_session_pool()->HasSession(test_hosts[1].pair));
822 826
823 session_->spdy_session_pool()->CloseAllSessions(); 827 session_->spdy_session_pool()->CloseAllSessions();
824 } 828 }
825 829
826 // It would be nice to also test the timeouts in SSLClientSocketPool. 830 // It would be nice to also test the timeouts in SSLClientSocketPool.
827 831
828 } // namespace 832 } // namespace
829 833
830 } // namespace net 834 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/ssl_client_socket_pool.cc ('k') | net/socket/ssl_client_socket_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698