Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 8787010: Android buildbot reliability fixes. (Closed)

Created:
9 years ago by John Grabowski
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Android buildbot reliability fixes. More changes to help make the chromium android buildbot more reliable. Unlikely to be comprehensive but in the right direction. BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113004

Patch Set 1 #

Total comments: 4

Patch Set 2 : apply bradnelson feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -17 lines) Patch
M build/android/emulator.py View 1 5 chunks +96 lines, -16 lines 0 comments Download
M build/android/run_tests.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
John Grabowski
y i no can find python reviewer ITO on Fri evening?
9 years ago (2011-12-03 01:48:12 UTC) #1
John Grabowski
+ more reviewers
9 years ago (2011-12-05 03:19:45 UTC) #2
bradn
lgtm http://codereview.chromium.org/8787010/diff/1/build/android/emulator.py File build/android/emulator.py (right): http://codereview.chromium.org/8787010/diff/1/build/android/emulator.py#newcode98 build/android/emulator.py:98: return ("emulator-%d" % port, port) single quotes http://codereview.chromium.org/8787010/diff/1/build/android/emulator.py#newcode128 ...
9 years ago (2011-12-05 04:56:12 UTC) #3
John Grabowski
Thx for review; all feedback applied.
9 years ago (2011-12-05 06:38:07 UTC) #4
bradn
lgtm
9 years ago (2011-12-05 19:08:02 UTC) #5
bradn
9 years ago (2011-12-05 19:08:08 UTC) #6
lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698