Issue 8787009: Add 3-stage animation for minimization of Panels on Win.

Issue 8787009: Add 3-stage animation for minimization of Panels on Win. (Closed)

Created:
9 years ago by Dmitry Titov

Modified:
9 years ago

Reviewers:
jianli

CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng, prasadt

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add 3-stage animation for minimization of Panels on Win. BUG=104645 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112931

Patch Set 4 : another build fix #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -10 lines)			Patch
	M	chrome/browser/ui/panels/panel_browser_view.h	View	1 2 3	2 chunks	+18 lines, -4 lines	0 comments	Download
	M	chrome/browser/ui/panels/panel_browser_view.cc	View	1 2 3	4 chunks	+48 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jianli

LGTM w/ a few nits. http://codereview.chromium.org/8787009/diff/1/chrome/browser/ui/panels/panel_browser_view.cc File chrome/browser/ui/panels/panel_browser_view.cc (right): http://codereview.chromium.org/8787009/diff/1/chrome/browser/ui/panels/panel_browser_view.cc#newcode48 chrome/browser/ui/panels/panel_browser_view.cc:48: private: nit: empty line ...

9 years ago (2011-12-03 01:08:05 UTC) #2

Dmitry Titov

9 years ago (2011-12-03 01:27:52 UTC) #3

http://codereview.chromium.org/8787009/diff/1/chrome/browser/ui/panels/panel_...
File chrome/browser/ui/panels/panel_browser_view.cc (right):

http://codereview.chromium.org/8787009/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_view.cc:48: private:
On 2011/12/03 01:08:06, jianli wrote:
> nit: empty line

Done.

http://codereview.chromium.org/8787009/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_view.cc:49: bool do_minimize_;
On 2011/12/03 01:08:06, jianli wrote:
> nit: probably for_minimize_ sounds better?

Done.

http://codereview.chromium.org/8787009/diff/1/chrome/browser/ui/panels/panel_...
chrome/browser/ui/panels/panel_browser_view.cc:69: value = progress *
animation_stop_to_show_titlebar_ /
On 2011/12/03 01:08:06, jianli wrote:
> nit: indenting

Done.

Expand Messages | Collapse Messages