Issue 8787007: Fix memory leak in unit_test SelectFileDialogExtensionTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8787007: Fix memory leak in unit_test SelectFileDialogExtensionTest (Closed)

Created:
9 years ago by James Cook

Modified:
9 years ago

Reviewers:
rginda

CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix memory leak in unit_test SelectFileDialogExtensionTest I recently landed a patch that defers the SelectFileDialog::Listener callback until the file picker window is closed. The test needed to be updated to simulate closing the window so that the Listener would delete itself. BUG=none TEST=unit_tests, memory waterfall Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112830

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/select_file_dialog_extension_unittest.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages