Delay autofill commits to reduce client to server traffic.

chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/autofill_profile.h"
 #include "chrome/browser/sync/profile_sync_service_harness.h"
 #include "chrome/browser/sync/test/integration/autofill_helper.h"
+#include "chrome/browser/sync/test/integration/bookmarks_helper.h"
 #include "chrome/browser/sync/test/integration/sync_test.h"
 #include "chrome/browser/webdata/autofill_entry.h"
 #include "chrome/browser/webdata/autofill_table.h"
 
 using autofill_helper::AddKeys;
 using autofill_helper::AddProfile;
 using autofill_helper::CreateAutofillProfile;
 using autofill_helper::GetAllKeys;
 using autofill_helper::GetAllProfiles;
 using autofill_helper::KeysMatch;
 using autofill_helper::ProfilesMatch;
 using autofill_helper::PROFILE_FRASIER;
 using autofill_helper::PROFILE_HOMER;
 using autofill_helper::PROFILE_MARION;
 using autofill_helper::PROFILE_NULL;
 using autofill_helper::RemoveKey;
 using autofill_helper::RemoveProfile;
 using autofill_helper::UpdateProfile;
+using bookmarks_helper::AddFolder;

[Raghu Simha, 2011/12/19 20:50:48]

Remove this.

[lipalani1, 2011/12/19 20:54:01]

Done.

+using bookmarks_helper::AddURL;
+using bookmarks_helper::IndexedURL;
+using bookmarks_helper::IndexedURLTitle;
+using bookmarks_helper::SetTitle;

[Raghu Simha, 2011/12/19 20:50:48]

Remove this.

[lipalani1, 2011/12/19 20:54:01]

Done.

 
 class TwoClientAutofillSyncTest : public SyncTest {
  public:
-  TwoClientAutofillSyncTest() : SyncTest(TWO_CLIENT) {}
+  TwoClientAutofillSyncTest() : SyncTest(TWO_CLIENT) {count = 0;}

[Raghu Simha, 2011/12/19 20:50:48]

nit: I think the style guide recommends spaces after / before the open / close
brace.

[lipalani1, 2011/12/19 20:54:01]

Done.

   virtual ~TwoClientAutofillSyncTest() {}
 
+  // We do this so as to make a change that will trigger the autofill to sync.
+  // By default autofill does not sync unless there is some other change.
+  void MakeABookmarkChange(int profile) {
+    AddURL(profile, IndexedURLTitle(count), GURL(IndexedURL(count)));
+    ++count;
+   }
  private:
+  int count;
   DISALLOW_COPY_AND_ASSIGN(TwoClientAutofillSyncTest);
 };
 
 // Flaky, http://crbug.com/102687
 IN_PROC_BROWSER_TEST_F(TwoClientAutofillSyncTest, FLAKY_WebDataServiceSanity) {
   ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
 
   // Client0 adds a key.
   std::set<AutofillKey> keys;
   keys.insert(AutofillKey("name0", "value0"));
@@ skipping 353 matching lines @@
                 AutofillType(EMAIL_ADDRESS),
                 exceeds_max_length_string);
   UpdateProfile(0,
                 GetAllProfiles(0)[0]->guid(),
                 AutofillType(ADDRESS_HOME_LINE1),
                 exceeds_max_length_string);
 
   ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
   ASSERT_FALSE(ProfilesMatch(0, 1));
 }