Delay autofill commits to reduce client to server traffic.

chrome/browser/sync/internal_api/sync_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_INTERNAL_API_SYNC_MANAGER_H_
 #define CHROME_BROWSER_SYNC_INTERNAL_API_SYNC_MANAGER_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/callback_forward.h"
+#include "base/time.h"
 #include "base/threading/thread_checker.h"
 #include "chrome/browser/sync/internal_api/change_record.h"
 #include "chrome/browser/sync/internal_api/configure_reason.h"
 #include "chrome/browser/sync/protocol/sync_protocol_error.h"
 #include "chrome/browser/sync/syncable/model_type.h"
 #include "chrome/browser/sync/util/weak_handle.h"
 #include "chrome/common/net/gaia/google_service_auth_error.h"
 
 class FilePath;
 
@@ skipping 26 matching lines @@
                                        // migration or upgrade.
   REASON_DECRYPTION = 2,               // The cryptographer requires a
                                        // passphrase for its first attempt at
                                        // decryption.
   REASON_SET_PASSPHRASE_FAILED = 3,    // The cryptographer requires a new
                                        // passphrase because its attempt at
                                        // decryption with the cached passphrase
                                        // was unsuccessful.
 };
 
+// Possible types of nudge delay for datatypes.
+// Note: These are just hints. If a sync happens then all dirty entries
+// would be committed as part of the sync.
+enum NudgeDelayType {

[tim (not reviewing), 2011/12/09 23:07:22]

Instead of 'Type', maybe 'Strategy' or 'Behavior'.

[lipalani1, 2011/12/15 01:35:16]

Done.

+  // Sync right away.
+  IMMEDIATE,
+
+  // Sync this change while syncing another change.
+  PIGGY_BACK_WITH_ANOTHER_CHANGE,

[tim (not reviewing), 2011/12/09 23:07:22]

I thought about this naming for a while since PIGGY_BACK (though pretty accurate
to those familiar with the term) wasn't my favorite.  How about ACCOMPANY,
SHADOW, TAG_ALONG, or STANDBY (much like taking a flight)?  (or ACCOMPANY_ONLY /
SHADOW_ONLY etc)

[lipalani1, 2011/12/15 01:35:16]

Done.

+
+  // The datatype does not use one of the predefined wait times but defines its
+  // own wait time logic for nudge.
+  CUSTOM,
+};
+
 // Contains everything needed to talk to and identify a user account.
 struct SyncCredentials {
   std::string email;
   std::string sync_token;
 };
 
 // SyncManager encapsulates syncable::DirectoryManager and serves as
 // the parent of all other objects in the sync API.  If multiple
 // threads interact with the same local sync repository (i.e. the same
 // sqlite database), they should share a single SyncManager instance.
@@ skipping 502 matching lines @@
   bool HasUnsyncedItems() const;
 
   // Functions used for testing.
 
   void TriggerOnNotificationStateChangeForTest(
       bool notifications_enabled);
 
   void TriggerOnIncomingNotificationForTest(
       const syncable::ModelTypeBitSet& model_types);
 
+  static const int kDefaultNudgeDelayMilliseconds;
+  static const int kPreferencesNudgeDelayMilliseconds;
+  static const int kPiggybackNudgeDelay;
+
  private:
+  FRIEND_TEST_ALL_PREFIXES(SyncManagerTest, NudgeDelayTest);
+
+  // For unit tests.
+  base::TimeDelta GetNudgeDelayTimeDelta(const syncable::ModelType& model_type);
+
   base::ThreadChecker thread_checker_;
 
   // An opaque pointer to the nested private class.
   SyncInternal* data_;
 
   DISALLOW_COPY_AND_ASSIGN(SyncManager);
 };
 
 bool InitialSyncEndedForTypes(syncable::ModelTypeSet types, UserShare* share);
 
 syncable::ModelTypeSet GetTypesWithEmptyProgressMarkerToken(
     const syncable::ModelTypeSet types,
     sync_api::UserShare* share);
 
 // Returns the string representation of a PassphraseRequiredReason value.
 std::string PassphraseRequiredReasonToString(PassphraseRequiredReason reason);
 
 }  // namespace sync_api
 
 #endif  // CHROME_BROWSER_SYNC_INTERNAL_API_SYNC_MANAGER_H_