Delay autofill commits to reduce client to server traffic.

chrome/browser/sync/engine/sync_scheduler_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop.h"
 #include "base/test/test_timeouts.h"
@@ skipping 462 matching lines @@
       zero(), NUDGE_SOURCE_NOTIFICATION, types3, FROM_HERE);
   RunLoop();
 
   ASSERT_EQ(1U, r2.snapshots.size());
   EXPECT_TRUE(CompareModelTypeBitSetToModelTypePayloadMap(types3,
       r2.snapshots[0]->source.types));
   EXPECT_EQ(GetUpdatesCallerInfo::NOTIFICATION,
             r2.snapshots[0]->source.updates_source);
 }
 
+// Test that nudges are coalesced.
+TEST_F(SyncSchedulerTest, NudgeCoalescingWithDifferentTimings) {
+  StartSyncScheduler(SyncScheduler::NORMAL_MODE);
+  RunLoop();
+
+  SyncShareRecords r;
+  EXPECT_CALL(*syncer(), SyncShare(_,_,_))
+      .WillOnce(DoAll(Invoke(sessions::test_util::SimulateSuccess),
+                      WithArg<0>(RecordSyncShare(&r))));
+  syncable::ModelTypeBitSet types1, types2, types3;
+  types1[syncable::BOOKMARKS] = true;
+  types2[syncable::AUTOFILL] = true;
+
+  // Create a huge time delay.
+  TimeDelta delay = TimeDelta::FromSeconds(1200);

[tim (not reviewing), 2011/12/09 23:07:22]

OCD nit :) I think FromDays(1) is more readable for this.  I used that elsewhere
in here for "big delays not meant to be hit".  I don't think there's anything in
test_timeouts for this type of value (or that we'd want to add it there,
necessarily).

[lipalani1, 2011/12/15 01:35:16]

Done.

+
+  scheduler()->ScheduleNudge(
+      delay, NUDGE_SOURCE_UNKNOWN, types1, FROM_HERE);
+
+  scheduler()->ScheduleNudge(
+      zero(), NUDGE_SOURCE_UNKNOWN, types2, FROM_HERE);
+
+  TimeTicks min_time = TimeTicks::Now();
+  TimeTicks max_time = TimeTicks::Now() + delay;
+
+  RunLoop();
+
+  // Make sure the sync has happened.
+  ASSERT_EQ(1U, r.snapshots.size());
+  EXPECT_TRUE(CompareModelTypeBitSetToModelTypePayloadMap(
+      types1 | types2, r.snapshots[0]->source.types));
+
+  // Make sure the sync happened at the right time.
+  EXPECT_GE(r.times[0], min_time);
+  EXPECT_LE(r.times[0], max_time);
+}
+
 // Test nudge scheduling.
 TEST_F(SyncSchedulerTest, NudgeWithPayloads) {
   StartSyncScheduler(SyncScheduler::NORMAL_MODE);
   RunLoop();
 
   SyncShareRecords records;
   syncable::ModelTypePayloadMap model_types_with_payloads;
   model_types_with_payloads[syncable::BOOKMARKS] = "test";
 
   EXPECT_CALL(*syncer(), SyncShare(_,_,_))
@@ skipping 584 matching lines @@
   PumpLoop();
   // Pump again to run job.
   PumpLoop();
 
   StopSyncScheduler();
 
   EXPECT_TRUE(expected == context()->previous_session_routing_info());
 }
 
 }  // namespace browser_sync