Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8787004: Make ChildProcessHost be used through an interface in content/public, instead of by inheritence. (Closed)

Created:
9 years ago by jam
Modified:
9 years ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, kkania, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., robertshield, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Make ChildProcessHost be used through an interface in content/public, instead of by inheritence. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112878

Patch Set 1 : '' #

Patch Set 2 : fix posix #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -610 lines) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_broker_host_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 6 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/service/service_process_control.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/service/service_utility_process_host.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M content/browser/browser_child_process_host.h View 3 chunks +6 lines, -4 lines 0 comments Download
M content/browser/browser_child_process_host.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/plugin_loader_posix.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/plugin_process_host.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 6 chunks +10 lines, -7 lines 0 comments Download
M content/browser/renderer_host/mock_render_process_host.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_unittest.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/utility_process_host.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 4 chunks +5 lines, -4 lines 0 comments Download
D content/common/child_process_host.h View 1 chunk +0 lines, -145 lines 0 comments Download
D content/common/child_process_host.cc View 1 chunk +0 lines, -282 lines 0 comments Download
A + content/common/child_process_host_impl.h View 1 5 chunks +23 lines, -75 lines 0 comments Download
A + content/common/child_process_host_impl.cc View 11 chunks +56 lines, -37 lines 0 comments Download
M content/content_common.gypi View 2 chunks +3 lines, -2 lines 0 comments Download
A content/public/common/child_process_host.h View 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years ago (2011-12-02 23:08:19 UTC) #1
Elliot Glaysher
9 years ago (2011-12-02 23:16:40 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698