Issue 8786015: Add mobile bookmarks folder to Mac bookmark menus (system and wrench), when the folder is non-empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8786015: Add mobile bookmarks folder to Mac bookmark menus (system and wrench), when the folder is non-empty. (Closed)

Created:
9 years ago by Ilya Sherman

Modified:
9 years ago

Reviewers:
mrossetti, dhollowa

CC:
chromium-reviews, sky

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add mobile bookmarks folder to Mac bookmark menus (system and wrench), when the folder is non-empty. Also, a bit of style cleanup in the related file. BUG=102714 TEST=Bookmark a page and add it to the "Mobile bookmarks" folder. Make sure the bookmark is now accessible from the system and wrench bookmark menus on Mac (but not from the Bookmarks bar). Then remove the bookmark, and make sure the empty "Mobile bookmarks" folder is no longer visible in either menu. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112875

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -15 lines)			Patch
	M	chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm	View		5 chunks	+23 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mrossetti

LGTM, but you should add testing steps to the description for what should happen when ...

9 years ago (2011-12-03 04:15:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/8786015/1

9 years ago (2011-12-03 04:29:00 UTC) #3

Change committed as 112875

Expand Messages | Collapse Messages