Issue 8786014: [Sync] Convert sessions/ directory to ModelEnumSet

Issue 8786014: [Sync] Convert sessions/ directory to ModelEnumSet (Closed)

Created:
9 years ago by akalin

Modified:
9 years ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Convert sessions/ directory to ModelEnumSet Second in a series of patches to replace ModelType{Bit,}Set with ModelEnumSet (which will then be renamed to ModelTypeSet). BUG=79970 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113351

Patch Set 1 #

Patch Set 2 : Sync to head #

Total comments: 2

Patch Set 3 : Upload correct diff #

Patch Set 4 : Sync to head #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -68 lines)			Patch
M	chrome/browser/sync/engine/syncer_proto_util.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/glue/data_type_manager_impl.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/sync/glue/data_type_manager_impl.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/glue/data_type_manager_impl_unittest.cc	View		6 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View	1	5 chunks	+21 lines, -22 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host_mock.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host_mock.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/internal_api/sync_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/js/js_sync_manager_observer_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/sessions/session_state.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/sessions/session_state.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/sessions/session_state_unittest.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/sessions/status_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/sessions/status_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/sessions/sync_session.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

akalin

+zea for review This is the last one for now (although I still have more ...

9 years ago (2011-12-03 03:15:37 UTC) #1

Nicolas Zea

LGTM http://codereview.chromium.org/8786014/diff/3001/chrome/browser/sync/engine/sync_scheduler.cc File chrome/browser/sync/engine/sync_scheduler.cc (right): http://codereview.chromium.org/8786014/diff/3001/chrome/browser/sync/engine/sync_scheduler.cc#newcode586 chrome/browser/sync/engine/sync_scheduler.cc:586: if (it2 == workers->end()) this file is already ...

9 years ago (2011-12-06 19:41:40 UTC) #3

akalin

http://codereview.chromium.org/8786014/diff/3001/chrome/browser/sync/engine/sync_scheduler.cc File chrome/browser/sync/engine/sync_scheduler.cc (right): http://codereview.chromium.org/8786014/diff/3001/chrome/browser/sync/engine/sync_scheduler.cc#newcode586 chrome/browser/sync/engine/sync_scheduler.cc:586: if (it2 == workers->end()) On 2011/12/06 19:41:40, nzea wrote: ...

9 years ago (2011-12-06 19:46:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/8786014/14001

9 years ago (2011-12-07 03:16:58 UTC) #5

Change committed as 113351

Expand Messages | Collapse Messages