webkit/media/audio_decoder.cc - Issue 8786013: Replace media::Limits struct with media::limits namespace and update documentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/media/audio_decoder.cc

Issue 8786013: Replace media::Limits struct with media::limits namespace and update documentation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix logic Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/media/audio_decoder.cc

diff --git a/webkit/media/audio_decoder.cc b/webkit/media/audio_decoder.cc

index 0a503d975da7c9df21e080b7d437ebc79767b463..6c95e70812e655461dd9f499508add540b1985d7 100644

--- a/webkit/media/audio_decoder.cc

+++ b/webkit/media/audio_decoder.cc

@@ -44,9 +44,9 @@ bool DecodeAudioFileData(

// Apply sanity checks to make sure crazy values aren't coming out of

// FFmpeg.

if (!number_of_channels ||

- number_of_channels > static_cast<size_t>(media::Limits::kMaxChannels) ||

- file_sample_rate < media::Limits::kMinSampleRate ||

- file_sample_rate > media::Limits::kMaxSampleRate)

+ number_of_channels > static_cast<size_t>(media::limits::kMaxChannels) ||

+ file_sample_rate < media::limits::kMinSampleRate ||

+ file_sample_rate > media::limits::kMaxSampleRate)

return false;

// TODO(crogers) : do sample-rate conversion with FFmpeg.

« no previous file with comments | « media/filters/video_renderer_base.cc ('k') | webkit/media/webmediaplayer_impl.cc » ('j') | no next file with comments »