Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1863)

Unified Diff: chrome/browser/resources/ntp4/trash.js

Issue 8786010: NTP4: Dragging app over trash should be more apparent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more review comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/ntp4/trash.js
diff --git a/chrome/browser/resources/ntp4/trash.js b/chrome/browser/resources/ntp4/trash.js
index ae4180c0a1c4fed7b0ca845391bdf4b87c622a3c..9dc21a30f091d146c17e51b77ea7778c0e931c7a 100644
--- a/chrome/browser/resources/ntp4/trash.js
+++ b/chrome/browser/resources/ntp4/trash.js
@@ -43,6 +43,7 @@ cr.define('ntp4', function() {
doDragOver: function(e) {
ntp4.getCurrentlyDraggingTile().dragClone.classList.add(
'hovering-on-trash');
+ this.classList.add('could-drop');
ntp4.setCurrentDropEffect(e.dataTransfer, 'move');
e.preventDefault();
},
@@ -65,6 +66,7 @@ cr.define('ntp4', function() {
var tile = ntp4.getCurrentlyDraggingTile();
tile.firstChild.removeFromChrome();
tile.landedOnTrash = true;
+ this.classList.remove('could-drop');
},
/**
@@ -74,6 +76,7 @@ cr.define('ntp4', function() {
doDragLeave: function(e) {
ntp4.getCurrentlyDraggingTile().dragClone.classList.remove(
'hovering-on-trash');
+ this.classList.remove('could-drop');
},
};
« chrome/browser/resources/ntp4/new_tab.css ('K') | « chrome/browser/resources/ntp4/new_tab.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698