Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8786004: Revert "Restrict extension features based on the extension type." (Closed)

Created:
9 years ago by Matt Perry
Modified:
9 years ago
Reviewers:
jstritar
CC:
chromium-reviews, jstritar+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert "Restrict extension features based on the extension type." This breaks some ChromeOS tests. Among the log output: "Feature 'chrome_url_overrides' is not allowed in this type of manifest." Original review: http://codereview.chromium.org/8654001 BUG=101992, 104103, chromium-os:23709 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -891 lines) Patch
M chrome/browser/extensions/chrome_app_api_browsertest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension.h View 10 chunks +33 lines, -19 lines 0 comments Download
M chrome/common/extensions/extension.cc View 45 chunks +178 lines, -91 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_constants.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_messages.cc View 2 chunks +2 lines, -4 lines 0 comments Download
D chrome/common/extensions/manifest.h View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/common/extensions/manifest.cc View 1 chunk +0 lines, -229 lines 0 comments Download
D chrome/common/extensions/manifest_unittest.cc View 1 chunk +0 lines, -392 lines 0 comments Download
M chrome/renderer/extensions/app_bindings.cc View 2 chunks +1 line, -2 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/background_permission.json View 1 chunk +0 lines, -17 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/disallow_hybrid_1.json View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/extensions/manifest_tests/disallow_hybrid_2.json View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/multiple_ui_surfaces.json View 1 chunk +0 lines, -6 lines 0 comments Download
A + chrome/test/data/extensions/manifest_tests/multiple_ui_surfaces_1.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/multiple_ui_surfaces_2.json View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/multiple_ui_surfaces_3.json View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Matt Perry
TBR
9 years ago (2011-12-02 22:49:08 UTC) #1
jstritar
Do you know which tests these were?
9 years ago (2011-12-03 02:01:41 UTC) #2
jstritar
NVM found them.
9 years ago (2011-12-03 02:03:58 UTC) #3
Matt Perry
9 years ago (2011-12-03 02:04:06 UTC) #4 
See
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/bui...

   1.
  
browser_tests<http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2145/steps/browser_tests>
browser_tests
   33 flaky failed 6
   Flakiness
dashboard<http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumChromiumOS&testType=browser_tests&tests=ExtensionURLRewriteBrowserTest.FileManagerURL,SelectFileDialogExtensionBrowserTest.SelectFileAndOpen,SelectFileDialogExtensionBrowserTest.OpenTwoDialogs,SelectFileDialogExtensionBrowserTest.SelectFileAndCancel,SelectFileDialogExtensionBrowserTest.SelectFileAndSave,SelectFileDialogExtensionBrowserTest.OpenSingletonTabAndCancel>
    ( 20 mins, 34 secs )
   1.
stdio<http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2145/steps/browser_tests/logs/stdio>
      2.
FileManagerURL<http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2145/steps/browser_tests/logs/FileManagerURL>
      3.
OpenSingletonTabAndCancel<http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2145/steps/browser_tests/logs/OpenSingletonTabAndCancel>
      4.
OpenTwoDialogs<http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2145/steps/browser_tests/logs/OpenTwoDialogs>
      5.
SelectFileAndCancel<http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2145/steps/browser_tests/logs/SelectFileAndCancel>
      6.
SelectFileAndOpen<http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2145/steps/browser_tests/logs/SelectFileAndOpen>
      7.
SelectFileAndSave<http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/2145/steps/browser_tests/logs/SelectFileAndSave>

On Fri, Dec 2, 2011 at 6:01 PM, <jstritar@chromium.org> wrote:

> Do you know which tests these were?
>
>
http://codereview.chromium.**org/8786004/<http://codereview.chromium.org/8786...
>

Powered by Google App Engine
This is Rietveld 408576698