Issue 8786003: GTK: Move tab_renderer_gtk.cc off of GetSurfaceNamed() and onto GetImageNamed().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8786003: GTK: Move tab_renderer_gtk.cc off of GetSurfaceNamed() and onto GetImageNamed(). (Closed)

Created:
9 years ago by Elliot Glaysher

Modified:
9 years ago

Reviewers:
Evan Stade

CC:
chromium-reviews, James Su

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

GTK: Move tab_renderer_gtk.cc off of GetSurfaceNamed() and onto GetImageNamed(). Also moves a bunch of mask images off the theme provider alltogether, which are now shared across profiles via gfx::Image. BUG=106060 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113097

Patch Set 1 #

Patch Set 2 : Rebase now that dependent patch is committed #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -40 lines)			Patch
	M	chrome/browser/ui/gtk/tabs/tab_renderer_gtk.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc	View		11 chunks	+37 lines, -39 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

http://codereview.chromium.org/8786003/diff/2001/chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc File chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc (right): http://codereview.chromium.org/8786003/diff/2001/chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc#newcode1111 chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc:1111: GdkPixbuf* tab_active_l = rb.GetNativeImageNamed(IDR_TAB_ACTIVE_LEFT); This makes sure that the ...

9 years ago (2011-12-05 22:52:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8786003/2001

9 years ago (2011-12-05 23:41:28 UTC) #3

Change committed as 113097

Expand Messages | Collapse Messages