Issue 8785021: Be Careful when Accessing Map

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8785021: Be Careful when Accessing Map (Closed)

Created:
9 years ago by mrossetti

Modified:
9 years ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Be Careful when Accessing Map Do not assume that the history_info_map_ will always contain entries for keys. BUG=106192 TEST=With a big History database, type a single 'w' and verify that a crash does not occur. 'w' is chosen since it occurs in the bulk of URLs ('www'). Other common characters to test singly are 'c', 'h', 'm', 'o', 'p' and 't'. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112910

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	chrome/browser/history/in_memory_url_index.cc	View		1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mrossetti

9 years ago (2011-12-03 22:33:51 UTC) #2

On Windows we're getting crashes on single character omnibox entries (see bug)
as the map entry in question is disappearing, possibly due to the expiry. This
change will eliminate access to stale map entries.

Expand Messages | Collapse Messages