Add menu option for disabling app notifications

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 0a8196db35f0baac222c48ba97c4e6eef29a7219..5155445aac25c6b8a9cffc4f63cb06b311dd7daf 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1444,6 +1444,10 @@ void ExtensionService::ProcessExtensionSyncData(
       bundle.pending_sync_data[extension_sync_data.id()] = extension_sync_data;
       CheckForUpdatesSoon();
     }
+    if (extension_sync_data.notifications_disabled() !=
+        extension_prefs_->IsAppNotificationDisabled(id))
+      extension_prefs_->SetAppNotificationDisabled(
+          id, extension_sync_data.notifications_disabled());

[Finnur, 2011/12/05 16:15:16]

Wait... Isn't one possibility here that app notifications is disabled for one
id, but extension sync data is enabled, so we flip the enabled bit for this id
to true?

Also, nit: Multi-line if clause, needs braces.

[asargent_no_longer_on_chrome, 2011/12/05 17:42:39]

|extension_sync_data| is specific to a particular extension (it's an object
encapsulating the state we push around via sync like enabled/disabled, allow in
incognito, etc.). Note that we grab |id| from it up above in this function.
 
Done.

   } else {
     // TODO(akalin): Replace silent update with a list of enabled
     // permissions.